[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30451: [SPARK-28704][SQL][TEST] Add back Skiped HiveExternalCatalogVersionsSuite in HiveSparkSubmitSuite at JDK9+

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #30451:
URL: https://github.com/apache/spark/pull/30451#discussion_r528215570



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala
##########
@@ -103,6 +103,7 @@ package object client {
     // Since HIVE-14496, Hive materialized view need calcite-core.
     // For spark, only VersionsSuite currently creates a hive materialized view for testing.
     case object v2_3 extends HiveVersion("2.3.7",
+      extraDeps = Seq("org.apache.zookeeper:zookeeper:3.4.6"),

Review comment:
       > Although we have this, the GitHub Action is stilling failing. Maybe, we have other issues?
   
   Since default hive version is 2.3.7 and 2.3.7 can pass jdk9+, so. I changed hive version. in HiveExternalCatalogVersionSuite.   It's reasonable.
   
   So confused, still working to find why it download zookeeper(test-jar).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org