[GitHub] [hudi] xicm commented on a diff in pull request #6986: [HUDI-5047] Add partition value in HoodieLogRecordReader when hoodie.datasource.write.drop.partition.columns=true

[GitBox <gi...@apache.org>]

xicm commented on code in PR #6986:
URL: https://github.com/apache/hudi/pull/6986#discussion_r1000314284


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/cdc/TestCDCDataFrameSuite.scala:
##########
@@ -593,8 +593,8 @@ class TestCDCDataFrameSuite extends HoodieCDCTestBase {
     // it will write out >1 cdc log files due to rollover.
     assert(cdcLogFiles2.size > 1)
     // with a small value for 'hoodie.logfile.data.block.max.size',
-    // it will write out >1 cdc data blocks in one single cdc log file.
-    assert(getCDCBlocks(cdcLogFiles2.head, cdcSchema).size > 1)
+    // it will write out >= 1 cdc data blocks in one single cdc log file.
+    assert(getCDCBlocks(cdcLogFiles2.head, cdcSchema).size >= 1)
 

Review Comment:
   Flaky test, the blocks may be 1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org