You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2017/03/29 17:29:36 UTC
Review Request 58032: DISPATCH-205: Schema.validate() called many
times
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58032/
-----------------------------------------------------------
Review request for qpid, Ganesh Murthy and Ted Ross.
Bugs: DISPATCH-205
https://issues.apache.org/jira/browse/DISPATCH-205
Repository: qpid-dispatch
Description
-------
Replace wildly inefficient validation scheme with one that checks each new
entity exactly once for unique attribute and singleton clashes.
Better error message for forbidden python imports
Diffs
-----
python/qpid_dispatch/management/entity.py 17ff00a286464f7b064a8a3295d26c94bcdd9985
python/qpid_dispatch_internal/dispatch.py e397f863cbbf34b0aa912c5d1043c7ff799b03b4
python/qpid_dispatch_internal/management/agent.py 7f50cb838ba65e84efd919fd445a0cf74dbcdcfd
python/qpid_dispatch_internal/management/qdrouter.py 5f219136b59f94fac944e58461cc6c3902461590
python/qpid_dispatch_internal/management/schema.py 7559c733b83375b99c5818e97bf38e4c89a8313e
python/qpid_dispatch_internal/management/schema_doc.py ecf2825ede1c266aa99066e5dd679d7713f615a7
tests/management/schema.py 9ab3fcfb9f474ed282d0b7c041f4f27d47d625e4
Diff: https://reviews.apache.org/r/58032/diff/1/
Testing
-------
passes ctest suite, manually verified calls to SchemaAttribute.validate() reduced about 10x during management tests.
Thanks,
Alan Conway
Re: Review Request 58032: DISPATCH-205: Schema.validate() called many
times
Posted by Ganesh Murthy <gm...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58032/#review170634
-----------------------------------------------------------
Ship it!
Ship It!
- Ganesh Murthy
On March 29, 2017, 5:29 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58032/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 5:29 p.m.)
>
>
> Review request for qpid, Ganesh Murthy and Ted Ross.
>
>
> Bugs: DISPATCH-205
> https://issues.apache.org/jira/browse/DISPATCH-205
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Replace wildly inefficient validation scheme with one that checks each new
> entity exactly once for unique attribute and singleton clashes.
>
> Better error message for forbidden python imports
>
>
> Diffs
> -----
>
> python/qpid_dispatch/management/entity.py 17ff00a286464f7b064a8a3295d26c94bcdd9985
> python/qpid_dispatch_internal/dispatch.py e397f863cbbf34b0aa912c5d1043c7ff799b03b4
> python/qpid_dispatch_internal/management/agent.py 7f50cb838ba65e84efd919fd445a0cf74dbcdcfd
> python/qpid_dispatch_internal/management/qdrouter.py 5f219136b59f94fac944e58461cc6c3902461590
> python/qpid_dispatch_internal/management/schema.py 7559c733b83375b99c5818e97bf38e4c89a8313e
> python/qpid_dispatch_internal/management/schema_doc.py ecf2825ede1c266aa99066e5dd679d7713f615a7
> tests/management/schema.py 9ab3fcfb9f474ed282d0b7c041f4f27d47d625e4
>
>
> Diff: https://reviews.apache.org/r/58032/diff/1/
>
>
> Testing
> -------
>
> passes ctest suite, manually verified calls to SchemaAttribute.validate() reduced about 10x during management tests.
>
>
> Thanks,
>
> Alan Conway
>
>