You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/12/17 08:38:32 UTC

[GitHub] [mynewt-core] kasjer commented on pull request #2441: hw/mcu/nordic/nrf52xxx: Using hfxo_request and release. Addresses #2393.

kasjer commented on pull request #2441:
URL: https://github.com/apache/mynewt-core/pull/2441#issuecomment-747295534


   @ncasaril this patch slightly changes how code used to work.
   Before it waited for XTAL to settle now it just starts it without waiting.
   I don't know the implication of this. I guess that when XTAL will start settle time is short enough and it does not matter
   when change form HFINT to HFXO will take place.
   On the other hand if XTAL fails to start (I'm not sure what are the odds for this provided that hardware is correct) code will ignore this and will continue to run on HFINT, while before the change, it would stuck in loop and probably watchdog would cause the reboot.
   That's why I added @wes3 as the original author who may have some insight.
   
   For me it looks OK


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org