You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/09/16 17:33:35 UTC
[GitHub] [accumulo] Manno15 opened a new pull request #1706: Related #1664. Allow Candidate batch size to be user configurable
Manno15 opened a new pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706
This is in relation to #1664. This allows the batch size for garbage collecting implemented in #1650 to be configurable.
After a discussion with @ctubbsii, I determined that I couldn't fully test out the upper limits (batch sizes of 64MB for example). With that in mind, I went ahead and made it configurable but kept it at its current default batch size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1706: Related #1664. Allow Candidate batch size to be user configurable
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706#discussion_r490255336
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -568,8 +568,8 @@
// accumulo garbage collector properties
GC_PREFIX("gc.", null, PropertyType.PREFIX,
"Properties in this category affect the behavior of the accumulo garbage collector."),
- GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "4000000", PropertyType.COUNT,
- "The batch size used for garbage collection. The default is effectively 8MB"),
+ GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "8m", PropertyType.BYTES,
Review comment:
Although our type engine is case-insensitive, it is better to use upper-case, so it looks like MegaBytes, and not milliBytes. :smiley_cat:
```suggestion
GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "8M", PropertyType.BYTES,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on a change in pull request #1706: Related #1664. Allow Candidate batch size to be user configurable
Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706#discussion_r490265322
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -568,8 +568,8 @@
// accumulo garbage collector properties
GC_PREFIX("gc.", null, PropertyType.PREFIX,
"Properties in this category affect the behavior of the accumulo garbage collector."),
- GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "4000000", PropertyType.COUNT,
- "The batch size used for garbage collection. The default is effectively 8MB"),
+ GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "8m", PropertyType.BYTES,
Review comment:
Fair, I had it capitalized but I didn't like the way it looked and saw we had a `1g` somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1706: Related #1664. Allow Candidate batch size to be user configurable
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1706: Related #1664. Allow Candidate batch size to be user configurable
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706#discussion_r490405602
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -568,8 +568,8 @@
// accumulo garbage collector properties
GC_PREFIX("gc.", null, PropertyType.PREFIX,
"Properties in this category affect the behavior of the accumulo garbage collector."),
- GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "4000000", PropertyType.COUNT,
- "The batch size used for garbage collection. The default is effectively 8MB"),
+ GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "8m", PropertyType.BYTES,
Review comment:
I'll take a look and make a separate PR to standardize everything on the case used by SI conventions, for all of our property descriptions and default values (uppercase for everything, except kilo, which is lowercase). It probably doesn't matter to anybody but me. :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1706: Related #1664. Allow Candidate batch size to be user configurable
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706#discussion_r489637965
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -568,6 +568,8 @@
// accumulo garbage collector properties
GC_PREFIX("gc.", null, PropertyType.PREFIX,
"Properties in this category affect the behavior of the accumulo garbage collector."),
+ GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "4000000", PropertyType.COUNT,
+ "The batch size used for garbage collection. The default is effectively 8MB"),
Review comment:
If we make this property of type `PropertyType.BYTES`, then it may be more user friendly, and the comment about the default can be removed, because it would be redundant. If you do that, then it's a simple matter to divide by 2 to get the approximate number of characters for the count in the implementation. Using `PropertyType.BYTES` will also make it more user friendly, because users can use the typed-strings, like `16M` or `1G` or `512K` when they change the configuration (and the default can be `8M`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org