You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "testikun (via GitHub)" <gi...@apache.org> on 2026/09/18 02:35:24 UTC
[I] feat(desktop): focus a file preview and keep the session composer in the document view [maka]
testikun opened a new issue, #5469:
URL: https://github.com/apache/maka/issues/5469
## Problem
Maka can show generated files in the Files tab of the session workbar next to the conversation, but the preview remains in a bounded right/bottom panel. Long Markdown documents cannot take over the content area for reading while the user continues the same conversation. The main composer is mounted in the conversation column; collapsing that column would also remove its input surface.
This is a document focus mode inside the Maka window, **not** operating-system fullscreen or dragging a file into the attachment input. The requested interaction is illustrated by a split chat/document view, a document-focused view without the left conversation column, and the same session composer appearing over the document near its bottom edge (for example after moving it there via drag).
## Desired outcome
- From an open Files preview, an explicit expand/restore control switches between split view (conversation on the left, document on the right) and focused document view (document uses the available content area; conversation column is hidden). Preserve the selected file and the document and conversation reading positions on return.
- The existing session composer can be moved into the document view (including through an obvious drag affordance, with a non-drag control/keyboard equivalent). In focused mode the user can always reach it near the bottom of the document without restoring the conversation. Restore its ordinary location when returning to split view unless the user has explicitly chosen another position.
- Input in either position targets **the same session and draft**: text, attachments/quotes, model and permission controls, send/stop, queued messages, and pending interaction state must not reset or fork. There must not be two independently editable composer instances.
- Keep document scrolling usable and text readable above the input; keyboard focus, Escape/restore behavior, screen-reader names, and narrow-window layout should be coherent. Session/file switches and closing a preview must not leave a stranded overlay or send to the wrong session.
## Current code and scope
- `apps/desktop/src/renderer/app-shell.tsx` mounts `ChatSurfaceLayout` and its `ChatComposerRegion` in `.mainColumn`, with `WorkbarHost` as a separate sibling.
- `features/workbar/model/workbar-layout.ts` tracks collapse, right width (340-600px), and bottom height, but no file-focus or composer-placement state. `features/workbar/tools/artifacts/artifact-pane.tsx` previews files inside the workbar.
- Start with files that the current Files panel can already preview. Existing workspace Markdown references should use the same focused view when the separate open-from-transcript work in #2664 is implemented; do not duplicate or bypass its path/sandbox rules.
## Acceptance scenarios
1. Open a generated Markdown file in Files: split view shows conversation and document; switching to focus hides the conversation column and widens the document, without entering OS fullscreen.
2. Move the composer onto the document by pointer and by a keyboard-accessible control; type and send there. The turn appears in the original session, and the document remains open. Return to split view with the draft and scroll positions intact.
3. Toggle focus repeatedly, resize the window, switch sessions/files, and close the preview: no lost draft, duplicated input, stale file overlay, or wrong-session send.
4. Add focused layout/state tests plus one representative desktop or Storybook interaction for split/focus, composer relocation, and return.
Related: #1031 established the right Files workbar; #2664 concerns opening workspace Markdown references and is complementary, not a duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] feat(desktop): focus a file preview and keep the session composer in the document view [maka]
Posted by "testikun (via GitHub)" <gi...@apache.org>.
testikun commented on issue #5469:
URL: https://github.com/apache/maka/issues/5469#issuecomment-5726395779
Scope update (2026-09-18): the focused preview should work for the existing Browser page as well as Files. Above the same mounted session composer, show one collapsible latest-turn panel: while a turn runs, expose its ordered visible text/tool stream and processing elapsed time; when it settles, keep the panel open/closed state and show the last persisted assistant reply from that same turn. Preserve draft, session ownership, document/browser scroll, and native browser viewport clearance at narrow widths. File-type behavior must retain current read/security limits; Markdown, source, diff, HTML, image and PDF use their existing renderers in the expanded space. Office binaries must not be decoded as text: use an explicit unsupported fallback. CSV/TSV tables, Office, and Notebook-specific previews need separate bounded parsing and tests before claiming support. Detailed local design and acceptance notes: docs/desktop-focused-preview.zh-CN.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] feat(desktop): focus a file preview and keep the session composer in the document view [maka]
Posted by "testikun (via GitHub)" <gi...@apache.org>.
testikun commented on issue #5469:
URL: https://github.com/apache/maka/issues/5469#issuecomment-5724302179
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] feat(desktop): focus a file preview and keep the session composer in the document view [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks closed issue #5469: feat(desktop): focus a file preview and keep the session composer in the document view
URL: https://github.com/apache/maka/issues/5469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org