[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9944: Clean up unused dependencies and packaging issues

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #9944:
URL: https://github.com/apache/dolphinscheduler/pull/9944#discussion_r867577310


##########
dolphinscheduler-master/pom.xml:
##########
@@ -67,11 +71,24 @@
                 </exclusion>
             </exclusions>
         </dependency>
-
         <dependency>
             <groupId>org.codehaus.janino</groupId>
             <artifactId>janino</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.hadoop</groupId>
+            <artifactId>hadoop-common</artifactId>
+            <exclusions>
+                <exclusion>
+                    <groupId>*</groupId>

Review Comment:
   Is it still need to import this jar package with exclusion *?



##########
dolphinscheduler-data-quality/pom.xml:
##########
@@ -171,34 +171,4 @@
         </dependency>
 
     </dependencies>
-
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-assembly-plugin</artifactId>
-                <version>2.2</version>
-                <configuration>
-                    <appendAssemblyId>false</appendAssemblyId>
-                    <descriptorRefs>
-                        <descriptorRef>jar-with-dependencies</descriptorRef>
-                    </descriptorRefs>
-                    <archive>
-                        <manifest>
-                            <mainClass>org.apache.dolphinscheduler.data.quality.DataQualityApplication</mainClass>
-                        </manifest>
-                    </archive>
-                </configuration>
-                <executions>
-                    <execution>
-                        <id>make-assembly</id>
-                        <phase>package</phase>
-                        <goals>
-                            <goal>single</goal>

Review Comment:
   I remember that the developer added this to improve the packaging speed. Will it have any effect after removing it?
   cc @zixi0825 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org