You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/16 09:08:19 UTC

[GitHub] [helix] jiajunwang commented on pull request #1594: Fix builds failing on some non-Oracle JDKs

jiajunwang commented on pull request #1594:
URL: https://github.com/apache/helix/pull/1594#issuecomment-745957862


   Thanks for the PR. Good catch! I agree with the change.
   
   After I search around, there is one thing I'd like to suggest in addition. There is another uncommon exception "org.apache.commons.lang3.NotImplementedException" used in InstancesAccessor.java. Do you think it makes sense to change that one as well in this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org