You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/08/26 16:15:30 UTC

[GitHub] vrozov commented on a change in pull request #1445: DRILL-6706: fixed null pointer exception in HashJoin

vrozov commented on a change in pull request #1445: DRILL-6706: fixed null pointer exception in HashJoin
URL: https://github.com/apache/drill/pull/1445#discussion_r212831254
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetSchema.java
 ##########
 @@ -228,7 +228,7 @@ public void createNonExistentColumns(OutputMutator output, List<NullableIntVecto
 
   private NullableIntVector createMissingColumn(SchemaPath col, OutputMutator output) throws SchemaChangeException {
     // col.toExpr() is used here as field name since we don't want to see these fields in the existing maps
-    MaterializedField field = MaterializedField.create(col.toExpr(),
+    MaterializedField field = MaterializedField.create(col.toExpr().replace('`',' ').trim(),
 
 Review comment:
   Why is it necessary to replace \` with a space to trim it later?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services