You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/07/17 21:47:59 UTC
Review Request 23654: Alerts: add AlertDefinition endpoint and resource
provider
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23654/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Tom Beerbower.
Bugs: AMBARI-6528
https://issues.apache.org/jira/browse/AMBARI-6528
Repository: ambari
Description
-------
Added endpoint and ResourceProvider for alert definitions. This is really just to get the endpoint going, and all the other CRUD operations will be in another JIRA. Also updated some DAO, Entity and SQL fixes from Jonathan.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 43578c6
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2a87c4f
ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 9bbebf5
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 29ca8a0
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 15c382b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d71cb8c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java f68f21c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b70f335
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 6f084df
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java c5a9186
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java aa99a08
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 98af71d
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 6df6be2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java c1e346a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java bc3958e
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 595a3b8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 44bc369
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a42153
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql deb70ab
ambari-server/src/main/resources/key_properties.json 68aa632
ambari-server/src/main/resources/properties.json a6cdac4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java a4ee74b
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 71bc1f8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java b34a7dd
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json PRE-CREATION
Diff: https://reviews.apache.org/r/23654/diff/
Testing
-------
Unit test and manual testing against the endpoint.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:53.464s
[INFO] Finished at: Thu Jul 17 15:34:30 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 23654: Alerts: add AlertDefinition endpoint and resource
provider
Posted by Nate Cole <nc...@hortonworks.com>.
> On July 17, 2014, 4:34 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java, line 48
> > <https://reviews.apache.org/r/23654/diff/1/?file=634520#file634520line48>
> >
> > We don't @Produce text/json ?
No. Originally was a way to easily view the API responses, and now it's just convention. Would probably be more proper for application/json
> On July 17, 2014, 4:34 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java, line 41
> > <https://reviews.apache.org/r/23654/diff/1/?file=634520#file634520line41>
> >
> > You dinged me once before on m_
I believe I dinged you on hungarian, not m_ ;) Followed other services' convention.
> On July 17, 2014, 4:34 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java, line 1071
> > <https://reviews.apache.org/r/23654/diff/1/?file=634521#file634521line1071>
> >
> > Gson instances are thread-safe; you could create a single instance to share over multiple invocations.
True. Will address in next patch.
> On July 17, 2014, 4:34 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java, line 163
> > <https://reviews.apache.org/r/23654/diff/1/?file=634526#file634526line163>
> >
> > Shared Gson?
Will address in next patch.
> On July 17, 2014, 4:34 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java, line 160
> > <https://reviews.apache.org/r/23654/diff/1/?file=634526#file634526line160>
> >
> > Missing "Source" in the data being returned?
Source isn't a string, it's an object:
{
"AlertDefinition": {
"source_type": "metric",
"metric": { /* some metric fields */ }
}
}
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23654/#review48047
-----------------------------------------------------------
On July 17, 2014, 3:47 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23654/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 3:47 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-6528
> https://issues.apache.org/jira/browse/AMBARI-6528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added endpoint and ResourceProvider for alert definitions. This is really just to get the endpoint going, and all the other CRUD operations will be in another JIRA. Also updated some DAO, Entity and SQL fixes from Jonathan.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 43578c6
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2a87c4f
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 9bbebf5
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 29ca8a0
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 15c382b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d71cb8c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java f68f21c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b70f335
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 6f084df
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java c5a9186
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java aa99a08
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 98af71d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 6df6be2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java c1e346a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java bc3958e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 595a3b8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 44bc369
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a42153
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql deb70ab
> ambari-server/src/main/resources/key_properties.json 68aa632
> ambari-server/src/main/resources/properties.json a6cdac4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java a4ee74b
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 71bc1f8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java b34a7dd
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23654/diff/
>
>
> Testing
> -------
>
> Unit test and manual testing against the endpoint.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:53.464s
> [INFO] Finished at: Thu Jul 17 15:34:30 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 23654: Alerts: add AlertDefinition endpoint and resource
provider
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23654/#review48047
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java
<https://reviews.apache.org/r/23654/#comment84299>
You dinged me once before on m_
ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java
<https://reviews.apache.org/r/23654/#comment84298>
We don't @Produce text/json ?
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
<https://reviews.apache.org/r/23654/#comment84300>
Gson instances are thread-safe; you could create a single instance to share over multiple invocations.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
<https://reviews.apache.org/r/23654/#comment84304>
Missing "Source" in the data being returned?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
<https://reviews.apache.org/r/23654/#comment84303>
Shared Gson?
- Jonathan Hurley
On July 17, 2014, 3:47 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23654/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 3:47 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-6528
> https://issues.apache.org/jira/browse/AMBARI-6528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added endpoint and ResourceProvider for alert definitions. This is really just to get the endpoint going, and all the other CRUD operations will be in another JIRA. Also updated some DAO, Entity and SQL fixes from Jonathan.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 43578c6
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2a87c4f
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 9bbebf5
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 29ca8a0
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 15c382b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d71cb8c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java f68f21c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b70f335
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 6f084df
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java c5a9186
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java aa99a08
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 98af71d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 6df6be2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java c1e346a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java bc3958e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 595a3b8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 44bc369
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a42153
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql deb70ab
> ambari-server/src/main/resources/key_properties.json 68aa632
> ambari-server/src/main/resources/properties.json a6cdac4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java a4ee74b
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 71bc1f8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java b34a7dd
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23654/diff/
>
>
> Testing
> -------
>
> Unit test and manual testing against the endpoint.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:53.464s
> [INFO] Finished at: Thu Jul 17 15:34:30 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 23654: Alerts: add AlertDefinition endpoint and resource
provider
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23654/#review48052
-----------------------------------------------------------
Looks good... just some nit-picky stuff.
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
<https://reviews.apache.org/r/23654/#comment84311>
public method should have doc.
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
<https://reviews.apache.org/r/23654/#comment84312>
Is the @RequiresSession annotation needed?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
<https://reviews.apache.org/r/23654/#comment84315>
Would isEnabled be a better name?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
<https://reviews.apache.org/r/23654/#comment84317>
Empty doc?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
<https://reviews.apache.org/r/23654/#comment84318>
Empty doc?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
<https://reviews.apache.org/r/23654/#comment84322>
Empty doc?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
<https://reviews.apache.org/r/23654/#comment84324>
Empty doc?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java
<https://reviews.apache.org/r/23654/#comment84326>
Empty doc?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java
<https://reviews.apache.org/r/23654/#comment84327>
Empty doc?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java
<https://reviews.apache.org/r/23654/#comment84329>
Empty doc? ... okay I'll stop pointing these out :)
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
<https://reviews.apache.org/r/23654/#comment84330>
Docs? and I don't think we are supposed to use @author.
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
<https://reviews.apache.org/r/23654/#comment84332>
How come only the postgres scripts?
- Tom Beerbower
On July 17, 2014, 7:47 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23654/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:47 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-6528
> https://issues.apache.org/jira/browse/AMBARI-6528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added endpoint and ResourceProvider for alert definitions. This is really just to get the endpoint going, and all the other CRUD operations will be in another JIRA. Also updated some DAO, Entity and SQL fixes from Jonathan.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 43578c6
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2a87c4f
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 9bbebf5
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 29ca8a0
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 15c382b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d71cb8c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java f68f21c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b70f335
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 6f084df
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java c5a9186
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java aa99a08
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 98af71d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 6df6be2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java c1e346a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java bc3958e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 595a3b8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 44bc369
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a42153
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql deb70ab
> ambari-server/src/main/resources/key_properties.json 68aa632
> ambari-server/src/main/resources/properties.json a6cdac4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java a4ee74b
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 71bc1f8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java b34a7dd
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23654/diff/
>
>
> Testing
> -------
>
> Unit test and manual testing against the endpoint.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:53.464s
> [INFO] Finished at: Thu Jul 17 15:34:30 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 23654: Alerts: add AlertDefinition endpoint and resource
provider
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23654/#review48119
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On July 17, 2014, 7:47 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23654/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:47 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-6528
> https://issues.apache.org/jira/browse/AMBARI-6528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added endpoint and ResourceProvider for alert definitions. This is really just to get the endpoint going, and all the other CRUD operations will be in another JIRA. Also updated some DAO, Entity and SQL fixes from Jonathan.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 43578c6
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2a87c4f
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 9bbebf5
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 29ca8a0
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 15c382b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d71cb8c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java f68f21c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b70f335
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 6f084df
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java c5a9186
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java aa99a08
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 98af71d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 6df6be2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java c1e346a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java bc3958e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 595a3b8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 44bc369
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a42153
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql deb70ab
> ambari-server/src/main/resources/key_properties.json 68aa632
> ambari-server/src/main/resources/properties.json a6cdac4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java a4ee74b
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 71bc1f8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java b34a7dd
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23654/diff/
>
>
> Testing
> -------
>
> Unit test and manual testing against the endpoint.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:53.464s
> [INFO] Finished at: Thu Jul 17 15:34:30 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 23654: Alerts: add AlertDefinition endpoint and resource
provider
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23654/#review48054
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On July 17, 2014, 3:47 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23654/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 3:47 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-6528
> https://issues.apache.org/jira/browse/AMBARI-6528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added endpoint and ResourceProvider for alert definitions. This is really just to get the endpoint going, and all the other CRUD operations will be in another JIRA. Also updated some DAO, Entity and SQL fixes from Jonathan.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 43578c6
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2a87c4f
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 9bbebf5
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 29ca8a0
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 15c382b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d71cb8c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java f68f21c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b70f335
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 6f084df
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java c5a9186
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java aa99a08
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 98af71d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 6df6be2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java c1e346a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java bc3958e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 595a3b8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 44bc369
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a42153
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql deb70ab
> ambari-server/src/main/resources/key_properties.json 68aa632
> ambari-server/src/main/resources/properties.json a6cdac4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java a4ee74b
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 71bc1f8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java b34a7dd
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23654/diff/
>
>
> Testing
> -------
>
> Unit test and manual testing against the endpoint.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:53.464s
> [INFO] Finished at: Thu Jul 17 15:34:30 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>