[GitHub] [zeppelin] cuspymd commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

[GitBox <gi...@apache.org>]

cuspymd commented on a change in pull request #4137:
URL: https://github.com/apache/zeppelin/pull/4137#discussion_r650643037



##########
File path: flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java
##########
@@ -319,4 +319,22 @@ public Map extractTableConfigOptions() {
     }
     return configOptions;
   }
+
+  @Override
+  public String[] row2String(Object row, Object table, Object tableConfig) {
+    return rowToString((Row) row);
+  }

Review comment:
       Wouldn't it be better to declare the parameter's type as a more specific type than `Object`?
   And it would be better to use either `row2String` or `rowToString` consistently.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org