You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/15 12:23:12 UTC

[GitHub] [arrow] thisisnic commented on pull request #10647: ARROW-13174: [C++][Compute] Add strftime kernel

thisisnic commented on pull request #10647:
URL: https://github.com/apache/arrow/pull/10647#issuecomment-880650445


   > @thisisnic this should unblock [ARROW-13133](https://issues.apache.org/jira/browse/ARROW-13133). Does the [R wrapper look ok](https://github.com/apache/arrow/pull/10647/files#diff-a138b87f0da58d824c72293eab62d9f352718dcb7f41a47ea7e1c3c84bbe27dd)? Note that `StrftimeOptions()` returns by default `StrftimeOptions("%Y-%m-%dT%H:%M:%S%z", "UTC")`.
   
   LGTM.
   
   Naive question: how does strftime return the correct local-specific time when using the format that outputs days of week? I see that in the base R implementation of strftime, it's not a parameter that's passed in; is this something that here is detected by the vendored date libraries that we're using?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org