You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/30 16:46:50 UTC

[PR] Remove useless NativeStorageContainerOption [shardingsphere]

terrymanu opened a new pull request, #39284:
URL: https://github.com/apache/shardingsphere/pull/39284

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove useless NativeStorageContainerOption [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39284:
URL: https://github.com/apache/shardingsphere/pull/39284#issuecomment-5133788175

   ### Result
   
   **Review Result: Mergeable**
   
   ### Evidence
   
   `StorageContainerConnectOption#getProxyURL` only delegates directly to `getURL`, and the production logic was not modified by this PR. No functional issue was found in removing `NativeStorageContainerOption` or replacing its call sites.
   
   ### Coverage
   
   All seven files in PR head `09fc72e86ac` were re-reviewed. The `test/e2e/env` module tests and the focused Oracle pipeline test both passed. This result covers code correctness only; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove useless NativeStorageContainerOption [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39284:
URL: https://github.com/apache/shardingsphere/pull/39284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org