You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/25 15:40:44 UTC
[GitHub] [pulsar-client-go] PowerStateFailure opened a new pull request #619: Fix ConsumersOpened counter not incremented when use multitopic or regexp consumer
PowerStateFailure opened a new pull request #619:
URL: https://github.com/apache/pulsar-client-go/pull/619
<--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
There was a kind of weird behavior when internal consumers created by multitopic- or regexp consumer are not counted as opened, but do as closed, so we can see in Prometheus that there were more consumers closed than opened.
### Modifications
Drop `topicSubscribe` function, increment `ConsumersOpened` counter on each success `newInternalConsumer` call similary to
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
### Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #619: Fix ConsumersOpened counter not incremented when use multitopic or regexp consumer
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #619:
URL: https://github.com/apache/pulsar-client-go/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #619: Fix ConsumersOpened counter not incremented when use multitopic or regexp consumer
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #619:
URL: https://github.com/apache/pulsar-client-go/pull/619#issuecomment-929296654
ping @PowerStateFailure please merge master code and fix Action CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #619: Fix ConsumersOpened counter not incremented when use multitopic or regexp consumer
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #619:
URL: https://github.com/apache/pulsar-client-go/pull/619#issuecomment-929296654
ping @PowerStateFailure please merge master code and fix Action CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #619: Fix ConsumersOpened counter not incremented when use multitopic or regexp consumer
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #619:
URL: https://github.com/apache/pulsar-client-go/pull/619#issuecomment-939244244
ping @PowerStateFailure please merge master code and fix the action CI, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] cckellogg commented on pull request #619: Fix ConsumersOpened counter not incremented when use multitopic or regexp consumer
Posted by GitBox <gi...@apache.org>.
cckellogg commented on pull request #619:
URL: https://github.com/apache/pulsar-client-go/pull/619#issuecomment-927498037
LGTM any idea why CI is failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org