[jira] [Updated] (BIGTOP-869) hadoop preun should not stop services itself on behalf of its subpackages

["Bruno Mahé (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BIGTOP-869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Mahé updated BIGTOP-869:
------------------------------

    Attachment: 0001-BIGTOP-869.-Hadoop-preun-should-not-stop-services-it.patch
    
> hadoop preun should not stop services itself on behalf of its subpackages
> -------------------------------------------------------------------------
>
>                 Key: BIGTOP-869
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-869
>             Project: Bigtop
>          Issue Type: Bug
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>         Attachments: 0001-BIGTOP-869.-Hadoop-preun-should-not-stop-services-it.patch
>
>
> Right now we have the following:
> {noformat}
>  %preun
>  if [ "$1" = 0 ]; then
>   # Stop any services that might be running
>   for service in %{hadoop_services}
>   do
>      service hadoop-$service stop 1>/dev/null 2>/dev/null || :
>   done
>    %{alternatives_cmd} --remove %{name}-conf %{etc_hadoop}/conf.empty || :
>  fi
> {noformat}
> But its subpackage also stop the services.
> Doing stop from from the main package AND the subpackages break the single responsibility principle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira