You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/23 21:04:01 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #11781: feat (dataset editor): allow Source tab readOnly mode
graceguo-supercat opened a new pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (ab8e674) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9b68b65568d24a0812ce35f949b0b026b3466864?el=desc) (9b68b65) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 63.64% 63.61% -0.03%
==========================================
Files 448 448
Lines 27567 27567
==========================================
- Hits 17544 17536 -8
- Misses 10023 10031 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `63.61% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9b68b65...ab8e674](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#discussion_r533797138
##########
File path: superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
##########
@@ -142,4 +147,65 @@ describe('DatasourceEditor', () => {
wrapper.find(Field).find({ fieldKey: 'fetch_values_predicate' }).exists(),
).toBe(true);
});
+
+ describe('enable edit Source tab', () => {
+ beforeAll(() => {
+ isFeatureEnabledMock = jest
+ .spyOn(featureFlags, 'isFeatureEnabled')
+ .mockImplementation(
+ feature => feature === 'ENABLE_DATASET_SOURCE_EDIT',
Review comment:
fixed. The logic here is **_if feature is not enabled_**, though used the wrong feature name, this feature "disable edit", is not enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#discussion_r529817675
##########
File path: superset/config.py
##########
@@ -300,6 +300,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
DEFAULT_FEATURE_FLAGS: Dict[str, bool] = {
# Experimental feature introducing a client (browser) cache
"CLIENT_CACHE": False,
+ "ENABLE_DATASET_SOURCE_EDIT": True,
Review comment:
nit: Can we name this `DISABLE_DATASET_SOURCE_EDIT` and set it to `False` by default? IMO every feature flag should be false by default, similar to every A/B testing experience starts with a current base (new feature being disabled) vs a new feature. We set to default feature flag to true only when we put an A/B testing full-on, but they will be cleaned up eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (5c50f41) into [master](https://codecov.io/gh/apache/incubator-superset/commit/84e0606a9050dffca59cd3f5284250d958381d42?el=desc) (84e0606) will **decrease** coverage by `4.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.62% 63.51% -4.11%
==========================================
Files 924 461 -463
Lines 44835 28338 -16497
Branches 4253 0 -4253
==========================================
- Hits 30319 17999 -12320
+ Misses 14413 10339 -4074
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.51% <ø> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [84e0606...5c50f41](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: feat (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (d7a23f9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.03%`.
> The diff coverage is `80.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.20% 63.16% -4.04%
==========================================
Files 903 903
Lines 43719 43725 +6
Branches 4199 4221 +22
==========================================
- Hits 29380 27621 -1759
- Misses 14235 15924 +1689
- Partials 104 180 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.88% <80.55%> (+0.04%)` | :arrow_up: |
| python | `63.33% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `84.04% <66.66%> (-7.27%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `66.51% <77.27%> (-4.78%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci50c3g=) | `82.90% <90.00%> (+0.60%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `90.47% <100.00%> (-9.53%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [db73869...d7a23f9](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736736341
> Sorry for keep nitpicking, but is there a way to add disabled state to the SQL editor as well? People might not know they need to scroll.
it is disabled, you can't edit text in SQL Editor. But you can't tell from screenshot. this component is set to disabled, but its UI is controlled by `react-ace` component.
By the way, i feel the padlock icon, it's hard to see `locked` or `unlocked`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `4.43%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 63.04% -4.44%
==========================================
Files 916 459 -457
Lines 44487 28101 -16386
Branches 4227 0 -4227
==========================================
- Hits 30020 17716 -12304
+ Misses 14364 10385 -3979
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.04% <ø> (-0.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [474 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `3.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.64% -3.69%
==========================================
Files 905 448 -457
Lines 43922 27567 -16355
Branches 4221 0 -4221
==========================================
- Hits 29570 17544 -12026
+ Misses 14249 10023 -4226
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.64% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...set-frontend/src/explore/components/ControlRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUm93LmpzeA==) | | |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | | |
| [...rontend/src/explore/components/AggregateOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZ2dyZWdhdGVPcHRpb24uanN4) | | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | | |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733939220
good reference: Mac (System Preferences > Security & Privacy) has a sim padlock experience. Some tabs allow editing some dont unless padlock is unlocked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733887688
@Steejay You design looks good!
Here's another alternative:
<img src="https://user-images.githubusercontent.com/335541/100269370-45600b00-2f0b-11eb-8820-70f98f578f24.png" width="600">
<img src="https://user-images.githubusercontent.com/335541/100269480-76404000-2f0b-11eb-9430-e3187c35a57e.png" width="600">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `3.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 63.91% -3.57%
==========================================
Files 916 459 -457
Lines 44487 28115 -16372
Branches 4227 0 -4227
==========================================
- Hits 30020 17971 -12049
+ Misses 14364 10144 -4220
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.91% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | | |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | | |
| [...ntend/src/dashboard/util/backgroundStyleOptions.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2JhY2tncm91bmRTdHlsZU9wdGlvbnMudHM=) | | |
| ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736597658
i'd recommend adhering to the alignment set by the original context to reduce visual clutter. Suggesting we move the lock to the bottom (but still inside the Source tab) so we dont break up the content of the form by having the padlock in the middle. Attached a mock for reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `3.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 63.49% -3.99%
==========================================
Files 916 459 -457
Lines 44487 28115 -16372
Branches 4227 0 -4227
==========================================
- Hits 30020 17851 -12169
+ Misses 14364 10264 -4100
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ø> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `85.30% <0.00%> (-2.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| ... and [458 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (ab8e674) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9b68b65568d24a0812ce35f949b0b026b3466864?el=desc) (9b68b65) will **decrease** coverage by `0.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 63.64% 62.93% -0.71%
==========================================
Files 448 448
Lines 27567 27567
==========================================
- Hits 17544 17349 -195
- Misses 10023 10218 +195
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `62.93% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9b68b65...ab8e674](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733224248
I agree with **edit** vs. **view** in future. In ideal case though, you don't have to go to the modal to view calculated metric's / column's definition. You can hover over it in the new left side bar and see the definition / calculation - the SQL expression basically. For now, I think the current solution is OK, and it's better to be on a safer side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: feat (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (d7a23f9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.31%`.
> The diff coverage is `80.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.20% 62.89% -4.32%
==========================================
Files 903 903
Lines 43719 43725 +6
Branches 4199 4221 +22
==========================================
- Hits 29380 27499 -1881
- Misses 14235 16046 +1811
- Partials 104 180 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.88% <80.55%> (+0.04%)` | :arrow_up: |
| python | `62.89% <ø> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `84.04% <66.66%> (-7.27%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `66.51% <77.27%> (-4.78%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci50c3g=) | `82.90% <90.00%> (+0.60%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `90.47% <100.00%> (-9.53%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [db73869...d7a23f9](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733173827
> When the enter through Data >Datasets>Edit, the padlock should not apply. In the latter case, the user's intent is clear, to edit the dataset, and the padlock can get annoying quickly.
Hi @benceorlai thanks for the feedback, but i could not agree with this point. When a dataset is large and shared by multiple users/teams, many time you want to _**check and make sure**_ the definition of its metrics and calculated columns before actually make chart out of it.
In the explore view context, i would believe the majority of use cases for Datasets > Edit, is to see dataset details instead of actual change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736736341
> Sorry for keep nitpicking, but is there a way to add disabled state to the SQL editor as well? People might not know they need to scroll.
it is disabled, you can't edit text in SQL Editor. But you can't tell from screenshot. this component is set to disabled, but its UI is controlled by `brace`.
By the way, i feel the padlock icon, it's hard to see `locked` or `unlocked`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `3.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.64% -3.69%
==========================================
Files 905 448 -457
Lines 43922 27567 -16355
Branches 4221 0 -4221
==========================================
- Hits 29570 17544 -12026
+ Misses 14249 10023 -4226
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.64% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | | |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | | |
| [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | | |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | | |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | | |
| [...nd/src/dashboard/util/findTabIndexByComponentId.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRUYWJJbmRleEJ5Q29tcG9uZW50SWQuanM=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736301212
Added additional description for the `padlock`:
Note: i still prefer to keep pad inside `Source` tab and not in the shared area with other tabs, just to make `Source` tab a little special.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736729684
looks good to me @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `3.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 63.55% -3.93%
==========================================
Files 916 459 -457
Lines 44487 28115 -16372
Branches 4227 0 -4227
==========================================
- Hits 30020 17868 -12152
+ Misses 14364 10247 -4117
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.55% <ø> (-0.44%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | | |
| ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733887688
@Steejay You design looks good!
Here's another alternative:
<img src="https://user-images.githubusercontent.com/335541/100269370-45600b00-2f0b-11eb-8820-70f98f578f24.png" width="600">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (5c50f41) into [master](https://codecov.io/gh/apache/incubator-superset/commit/84e0606a9050dffca59cd3f5284250d958381d42?el=desc) (84e0606) will **decrease** coverage by `4.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.62% 63.54% -4.09%
==========================================
Files 924 461 -463
Lines 44835 28338 -16497
Branches 4253 0 -4253
==========================================
- Hits 30319 18006 -12313
+ Misses 14413 10332 -4081
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.54% <ø> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [473 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [84e0606...5c50f41](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] benceorlai commented on pull request #11781: feat (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
benceorlai commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733156821
I think the padlock should apply only when the user enters the Dataset edit screen from Explore. When the enter through Data >Datasets>Edit, the padlock should not apply. In the latter case, the user's intent is clear, to edit the dataset, and the padlock can get annoying quickly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733920959
@ktmud and @Steejay Your design looks good, but please note only `Source` tab has need control. Both header and footer section, are shared with other tabs. We can do hide and show for Padlock if user is in other tab, but I just want to emphasis **"Source" tab** need extra careful protection.
Mostly cases, when user edit Metrics or Columns, they can find error and recover it right away. (Remove existed metrics and columns are dangerous too, you might remove something other ppl use). This also happens pretty often, so we don't want to add extra click for modify Metrics and Columns tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (5c50f41) into [master](https://codecov.io/gh/apache/incubator-superset/commit/84e0606a9050dffca59cd3f5284250d958381d42?el=desc) (84e0606) will **decrease** coverage by `4.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.62% 63.53% -4.10%
==========================================
Files 924 461 -463
Lines 44835 28353 -16482
Branches 4253 0 -4253
==========================================
- Hits 30319 18013 -12306
+ Misses 14413 10340 -4073
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.53% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [84e0606...5c50f41](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733974901
The extra feature flag `DISABLE_DATASET_SOURCE_EDIT`, only meant to disable other user change dataset, but allow different teams to enrich dataset. Additional Padlock will make add/modify metric and columns more troublesome, which happens very often in airbnb.
@ktmud and @Steejay I think for this PR we should focus on implementing the options raised and discussed on last meetup: https://github.com/apache/incubator-superset/issues/11478#issuecomment-720125272
If you have more options, bring up to meetup (or SIP) and get feedback from more audience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733974901
The extra feature flag `DISABLE_DATASET_SOURCE_EDIT`, only meant to disable other user change dataset, but allow teams to enrich dataset. Additional Padlock will make add/modify metric and columns more troublesome, which happens very often in airbnb.
@ktmud and @Steejay I think for this PR we should follow the agreement from last meetup: https://github.com/apache/incubator-superset/issues/11478#issuecomment-720125272
If you have more options, bring up to meetup and get feedback from more audience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733974901
The extra feature flag `DISABLE_DATASET_SOURCE_EDIT`, only meant to disable other user change dataset, but allow different teams to enrich dataset. Additional Padlock will make add/modify metric and columns more troublesome, which happens very often in airbnb.
@ktmud and @Steejay I think for this PR we should follow the agreement from last meetup: https://github.com/apache/incubator-superset/issues/11478#issuecomment-720125272
If you have more options, bring up to meetup (or SIP) and get feedback from more audience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `3.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 63.55% -3.93%
==========================================
Files 916 459 -457
Lines 44487 28115 -16372
Branches 4227 0 -4227
==========================================
- Hits 30020 17868 -12152
+ Misses 14364 10247 -4117
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.55% <ø> (-0.44%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | | |
| ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733223335
here is a real example: a calculated column `Capped duration`:
<img width="888" alt="Screen Shot 2020-11-24 at 12 40 50 PM" src="https://user-images.githubusercontent.com/27990562/100149045-74667600-2e52-11eb-970c-5b805756a75e.png">
When a dataset has a lot of calculated columns and metrics, users have to visit this pretty often to make sure the definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11781: feat (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (d7a23f9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.20% 62.53% -4.68%
==========================================
Files 903 446 -457
Lines 43719 27409 -16310
Branches 4199 0 -4199
==========================================
- Hits 29380 17139 -12241
+ Misses 14235 10270 -3965
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.53% <ø> (-0.96%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [472 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [db73869...d7a23f9](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (ab8e674) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9b68b65568d24a0812ce35f949b0b026b3466864?el=desc) (9b68b65) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 63.64% 63.60% -0.04%
==========================================
Files 448 448
Lines 27567 27567
==========================================
- Hits 17544 17533 -11
- Misses 10023 10034 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `63.60% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9b68b65...ab8e674](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (ab8e674) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9b68b65568d24a0812ce35f949b0b026b3466864?el=desc) (9b68b65) will **decrease** coverage by `0.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 63.64% 62.99% -0.65%
==========================================
Files 448 448
Lines 27567 27567
==========================================
- Hits 17544 17366 -178
- Misses 10023 10201 +178
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `62.99% <ø> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9b68b65...ab8e674](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733974901
The extra feature flag `DISABLE_DATASET_SOURCE_EDIT`, only meant to disable other user change dataset, but allow teams to enrich dataset. Additional Padlock will make add/modify metric and columns more troublesome, which happens very often in airbnb.
@ktmud and @Steejay I think for this PR we should follow the agreement from last meetup: https://github.com/apache/incubator-superset/issues/11478#issuecomment-720125272
If you have more options, bring up to meetup (or SIP) and get feedback from more audience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733224248
I agree with **edit** vs. **view** in future. In ideal case though, you don't have to go to the modal to view calculated metric's / column's definition. You can hover over it in the new left side bad and see the definition / calculation - the SQL expression basically. For now, I think the current solution is OK, and it's better to be on a safer side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733872951
I'm not sure how to do it, but should we place the padlock near the input fields? I'm worried users wouldn't know it's clickable. It would also be nice to have some tooltip or explanatory text on why it is locked.
Or, we can place a "Unlock Edit" link in the warning alert (potentially restyle it to make it more visible).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#discussion_r529817675
##########
File path: superset/config.py
##########
@@ -300,6 +300,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
DEFAULT_FEATURE_FLAGS: Dict[str, bool] = {
# Experimental feature introducing a client (browser) cache
"CLIENT_CACHE": False,
+ "ENABLE_DATASET_SOURCE_EDIT": True,
Review comment:
nit: Can we name this `DISABLE_DATASET_SOURCE_EDIT` and set it to `False` by default? IMO every feature flag should be false by default, similar to every A/B testing experience starts with a current base (new feature being disabled) vs a new feature. We set the default of a feature flag to `true` only when we put an A/B testing full-on, but they will be cleaned up eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#discussion_r533724187
##########
File path: superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
##########
@@ -142,4 +147,65 @@ describe('DatasourceEditor', () => {
wrapper.find(Field).find({ fieldKey: 'fetch_values_predicate' }).exists(),
).toBe(true);
});
+
+ describe('enable edit Source tab', () => {
+ beforeAll(() => {
+ isFeatureEnabledMock = jest
+ .spyOn(featureFlags, 'isFeatureEnabled')
+ .mockImplementation(
+ feature => feature === 'ENABLE_DATASET_SOURCE_EDIT',
Review comment:
I think this should be updated to `DISABLE_DATASET_SOURCE_EDIT` as well.
Why did the test pass even when the feature flag is not correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733920959
@ktmud and @Steejay Your design looks good, but please note only `Source` tab has ReadOnly control. Both header and footer section, are shared with other tabs. We can do hide and show for Padlock if user is in other tab, but I just want to emphasis **"Source" tab** need extra careful protection. I do not want to share Padlock with other tabs with intention.
Mostly cases, when user edit Metrics or Columns, they can find error and recover it right away. (Remove existed metrics and columns are dangerous too, you might remove something other ppl use). Edit Metrics and Calculated Columns also happens pretty often, so we don't want to add extra click for this operation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `3.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.64% -3.69%
==========================================
Files 905 448 -457
Lines 43922 27567 -16355
Branches 4221 0 -4221
==========================================
- Hits 29570 17544 -12026
+ Misses 14249 10023 -4226
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.64% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | | |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | | |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | | |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | | |
| [superset-frontend/src/explore/AdhocFilter.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NGaWx0ZXIuanM=) | | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733920959
We need extra protection here because current change in Source Tab is confusing. **_It looks like to build a chart from different dataset, but actually it is to change the tables used by that dataset_**. If i created a dataset and share this dataset with others, I would allow other ppl add metrics or columns, but I would not want someone change the tables for my dataset. If needed you should create (or copy) your own dataset.
Edit metrics and columns is different: it won't change the tables that defines this dataset. When user edit Metrics or Columns, they can find error and recover it right away. (Remove existed metrics and columns are dangerous too, you might remove something other ppl use). Edit Metrics and Calculated Columns also happens pretty often, so we don't want to add extra click for this operation.
@ktmud and @Steejay Your design looks good, but please note only `Source` tab has ReadOnly control. Both header and footer section, are shared with other tabs. We can do hide and show for Padlock if user is in other tab, but I just want to emphasis **"Source" tab** need extra careful protection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736736341
> Sorry for keep nitpicking, but is there a way to add disabled state to the SQL editor as well? People might not know they need to scroll.
it is disabled, you can't edit text in SQL Editor. But you can't tell from screenshot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `3.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 63.91% -3.57%
==========================================
Files 916 459 -457
Lines 44487 28115 -16372
Branches 4227 0 -4227
==========================================
- Hits 30020 17971 -12049
+ Misses 14364 10144 -4220
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.91% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=) | | |
| [...ntend/src/components/Checkbox/Checkbox.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3guc3Rvcmllcy5qc3g=) | | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | | |
| [...d/util/logging/getLoadStatsPerTopLevelComponent.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZ2V0TG9hZFN0YXRzUGVyVG9wTGV2ZWxDb21wb25lbnQuanM=) | | |
| ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: feat (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (d7a23f9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.20% 62.89% -4.32%
==========================================
Files 903 446 -457
Lines 43719 27409 -16310
Branches 4199 0 -4199
==========================================
- Hits 29380 17238 -12142
+ Misses 14235 10171 -4064
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.89% <ø> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.08% <0.00%> (-0.15%)` | :arrow_down: |
| ... and [457 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [db73869...d7a23f9](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733933339
The warning text applies to other tabs so I think it makes sense to apply the lock to other tabs, too. As you have noted, deleting a metric/column is also dangerous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733920959
We need extra protection here because current change in Source Tab is confusing. **_It looks like to build a chart from different dataset, but actually it is to change the tables used by that dataset_**. If i created a dataset and share this dataset with others, I would allow other ppl add metrics or columns, but I would not want someone change the tables for my dataset. If needed you should create (or copy) your own dataset.
Edit metrics and columns is different: it won't change the tables that defines this dataset. When user edit Metrics or Columns, they can find error and recover it right away. (Remove existed metrics and columns are dangerous too, you might remove something other ppl use). Edit Metrics and Calculated Columns also happens pretty often, so we don't want to add extra click for this operation.
@ktmud and @Steejay Your design looks good, but please note only `Source` tab has ReadOnly control. Both header and footer section, are shared with other tabs. We can do hide and show for Padlock if user is in other tab, but I just want to emphasis **"Source" tab** need extra careful protection. I do not want to share Padlock with other tabs with intention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `0.01%`.
> The diff coverage is `80.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 67.46% -0.02%
==========================================
Files 916 916
Lines 44487 44512 +25
Branches 4227 4249 +22
==========================================
+ Hits 30020 30032 +12
- Misses 14364 14377 +13
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.25% <63.63%> (+0.13%)` | :arrow_up: |
| javascript | `62.96% <80.55%> (+0.04%)` | :arrow_up: |
| python | `63.91% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `90.42% <66.66%> (-0.88%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `73.12% <77.27%> (+1.83%)` | :arrow_up: |
| [superset-frontend/src/components/TableSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci50c3g=) | `85.24% <90.00%> (+0.50%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `3.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.47% -3.86%
==========================================
Files 905 448 -457
Lines 43922 27567 -16355
Branches 4221 0 -4221
==========================================
- Hits 29570 17497 -12073
+ Misses 14249 10070 -4179
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | | |
| ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736735205
Sorry for keep nitpicking, but is there a way to add disabled state to the SQL editor as well? People might not know they need to scroll.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736301212
Added additional description for the `padlock`:
Note: i still prefer to keep padlock inside `Source` tab and not in the shared area with other tabs, just to make `Source` tab a little special.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `3.91%`.
> The diff coverage is `80.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 63.56% -3.92%
==========================================
Files 916 916
Lines 44487 44504 +17
Branches 4227 4249 +22
==========================================
- Hits 30020 28291 -1729
- Misses 14364 16034 +1670
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.96% <80.55%> (+0.04%)` | :arrow_up: |
| python | `63.91% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `84.04% <66.66%> (-7.27%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `66.51% <77.27%> (-4.78%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci50c3g=) | `85.24% <90.00%> (+0.50%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `86.95% <100.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736718166
> i'd recommend adhering to the alignment set by the original context to reduce visual clutter. Suggesting we move the lock to the bottom (but still inside the Source tab) so we dont break up the content of the form by having the padlock in the middle. Attached a mock for reference.
>
> 
Curious to see how does this look in the virtual datasource tab though? There's a very tall code editor that takes a lot of space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `4.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 62.98% -4.34%
==========================================
Files 905 448 -457
Lines 43922 27556 -16366
Branches 4221 0 -4221
==========================================
- Hits 29570 17356 -12214
+ Misses 14249 10200 -4049
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.98% <ø> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736893768
for the previous comments:
1) I shorten the Editor height from 24 lines => 20 lines. I don't want to make this really small because in airbnb many virtual dataset are huge...
2) I added grey background for the readOnly mode for Editor. please see the updated UI in description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: feat (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (d7a23f9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.04%`.
> The diff coverage is `80.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.20% 63.16% -4.05%
==========================================
Files 903 903
Lines 43719 43736 +17
Branches 4199 4221 +22
==========================================
- Hits 29380 27624 -1756
- Misses 14235 15932 +1697
- Partials 104 180 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.88% <80.55%> (+0.04%)` | :arrow_up: |
| python | `63.32% <ø> (-0.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `84.04% <66.66%> (-7.27%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `66.51% <77.27%> (-4.78%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci50c3g=) | `82.90% <90.00%> (+0.60%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `90.47% <100.00%> (-9.53%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [db73869...d7a23f9](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `3.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.48% -3.84%
==========================================
Files 905 448 -457
Lines 43922 27556 -16366
Branches 4221 0 -4221
==========================================
- Hits 29570 17494 -12076
+ Misses 14249 10062 -4187
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.48% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.61% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.31% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [455 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733861694
> When a dataset has a lot of calculated columns and metrics, users have to visit this pretty often to make sure the definition.
Not sure if everyone knows this, but you can hover on the little help icon after a pre-defined metric/calculated column to see its definition:
<img src="https://user-images.githubusercontent.com/335541/100265143-aa643280-2f04-11eb-939f-575aeb07bf38.png" width="300" />
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `3.84%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.47% -3.85%
==========================================
Files 905 448 -457
Lines 43922 27567 -16355
Branches 4221 0 -4221
==========================================
- Hits 29570 17498 -12072
+ Misses 14249 10069 -4180
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (-0.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | | |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733195956
@benceorlai i think the idea of _viewing_ the dataset properties has merits but doesn't necessarily need to be a part of the modal experience itself. if the majority of the use cases are to "see dataset details instead of actually changing it" or (similarly) "check and make sure" the properties are right, there could be an opportunity to expose this info in the side panel _before_ entering the "Edit Dataset" flow. Sim to what we have here but make this view more accessible:
<img width="585" alt="Screen Shot 2020-11-24 at 11 47 39 AM" src="https://user-images.githubusercontent.com/60786102/100143912-dcb15980-2e4a-11eb-99a2-3fa4cc23d44e.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736729010
move padlock to the bottom of Source tab:
The SQL Editor has fixed 25 lines of height.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] benceorlai commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
benceorlai commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733186632
> > When the enter through Data >Datasets>Edit, the padlock should not apply. In the latter case, the user's intent is clear, to edit the dataset, and the padlock can get annoying quickly.
>
> Hi @benceorlai thanks for the feedback, but i could not agree with this point. When a dataset is large and shared by multiple users/teams, many time you want to _**check and make sure**_ the definition of its metrics and calculated columns before actually make chart out of it.
>
> In the explore view context, i would believe the majority of use cases for Datasets > Edit, is to see dataset details instead of actual change it.
That's an interesting point you raise, and then the solution could be the introduction of a new "View" action, in addition to "Edit". My approach to this is to align the user intent and the UX, and I think the "Edit" term is very unambiguous to know what the user should expect. It seems that View (=see details), Edit (=make global changes) and Copy (=make 1-off changes) options would cover every possible intent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `4.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.03% -4.29%
==========================================
Files 905 448 -457
Lines 43922 27556 -16366
Branches 4221 0 -4221
==========================================
- Hits 29570 17371 -12199
+ Misses 14249 10185 -4064
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.03% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733223335
here is a real example: a calculated column `Capped duration`:
<img width="888" alt="Screen Shot 2020-11-24 at 12 40 50 PM" src="https://user-images.githubusercontent.com/27990562/100149045-74667600-2e52-11eb-970c-5b805756a75e.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (b16549d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/75086f8979c68d07ac1b7381beb1ff12f02ba23a?el=desc) (75086f8) will **decrease** coverage by `3.84%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.32% 63.47% -3.85%
==========================================
Files 905 448 -457
Lines 43922 27567 -16355
Branches 4221 0 -4221
==========================================
- Hits 29570 17498 -12072
+ Misses 14249 10069 -4180
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (-0.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [75086f8...b16549d](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (c9624eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c69679e14c2fa2b031c5c22b5cb95b640925176?el=desc) (9c69679) will **decrease** coverage by `0.13%`.
> The diff coverage is `80.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.48% 67.34% -0.14%
==========================================
Files 916 916
Lines 44487 44512 +25
Branches 4227 4249 +22
==========================================
- Hits 30020 29976 -44
- Misses 14364 14429 +65
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.65% <63.63%> (-0.46%)` | :arrow_down: |
| javascript | `62.96% <80.55%> (+0.04%)` | :arrow_up: |
| python | `63.91% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `89.36% <66.66%> (-1.95%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `73.12% <77.27%> (+1.83%)` | :arrow_up: |
| [superset-frontend/src/components/TableSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci50c3g=) | `85.24% <90.00%> (+0.50%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9c69679...c9624eb](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#discussion_r530046140
##########
File path: superset/config.py
##########
@@ -300,6 +300,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
DEFAULT_FEATURE_FLAGS: Dict[str, bool] = {
# Experimental feature introducing a client (browser) cache
"CLIENT_CACHE": False,
+ "ENABLE_DATASET_SOURCE_EDIT": True,
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (ab8e674) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9b68b65568d24a0812ce35f949b0b026b3466864?el=desc) (9b68b65) will **decrease** coverage by `0.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 63.64% 63.44% -0.20%
==========================================
Files 448 448
Lines 27567 27567
==========================================
- Hits 17544 17490 -54
- Misses 10023 10077 +54
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `63.44% <ø> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.36% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [9b68b65...ab8e674](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-736736341
> Sorry for keep nitpicking, but is there a way to add disabled state to the SQL editor as well? People might not know they need to scroll.
it is disabled, you can't edit text in SQL Editor. But you can't tell from screenshot. this component is set to disabled, but its UI is controlled by `brace`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733878285
@ktmud thinking we could position the padlock here w the supporting copy.
<img width="551" alt="Screen Shot 2020-11-25 at 10 26 40 AM" src="https://user-images.githubusercontent.com/60786102/100267727-c073f200-2f08-11eb-94fe-1882b457ef30.png">
<img width="508" alt="Screen Shot 2020-11-25 at 10 26 47 AM" src="https://user-images.githubusercontent.com/60786102/100267733-c36ee280-2f08-11eb-9b9a-d674a96619db.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on pull request #11781: fix (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733890677
that could work too @ktmud! i think it would be nice to keep all action buttons in the same region though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11781: feat (dataset editor): allow Source tab readOnly mode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-732428582
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=h1) Report
> Merging [#11781](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=desc) (d7a23f9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11781 +/- ##
==========================================
- Coverage 67.20% 62.83% -4.37%
==========================================
Files 903 446 -457
Lines 43719 27409 -16310
Branches 4199 0 -4199
==========================================
- Hits 29380 17222 -12158
+ Misses 14235 10187 -4048
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.83% <ø> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11781/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=footer). Last update [db73869...d7a23f9](https://codecov.io/gh/apache/incubator-superset/pull/11781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org