You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/01/02 20:01:36 UTC
Re: Review Request 71864: Moved creating authorization Object out of
`Master::authorize*reserve`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71864/
-----------------------------------------------------------
(Updated Jan. 2, 2020, 8:01 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Bugs: MESOS-10023 and MESOS-10056
https://issues.apache.org/jira/browse/MESOS-10023
https://issues.apache.org/jira/browse/MESOS-10056
Repository: mesos
Description (updated)
-------
NOTE: This patch also partially addresses MESOS-9562 issue
by modifying the logic of authorizing UNRESERVE operations.
Now, if some reservations have no principal, both authorization of
UNRESERVE_RESOURCES for ANY object and authorizations for unreserving
all reservations that have principals will be requested.
Diffs (updated)
-----
src/master/authorization.hpp PRE-CREATION
src/master/authorization.cpp PRE-CREATION
src/master/http.cpp 72587bf054e413402ebf4c6ff8060f7ca8ffcf1b
src/master/master.hpp f97b085ae908278731acd326df68f9f381f09483
src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869
Diff: https://reviews.apache.org/r/71864/diff/2/
Changes: https://reviews.apache.org/r/71864/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 71864: Moved creating authorization Object out of
`Master::authorize*reserve`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71864/#review219150
-----------------------------------------------------------
Ship it!
src/master/authorization.hpp
Lines 109-125 (patched)
<https://reviews.apache.org/r/71864/#comment307253>
I suppose this could have just been in the .cpp file rather than a static member exposed up in the header?
src/master/authorization.cpp
Lines 146-147 (patched)
<https://reviews.apache.org/r/71864/#comment307254>
seems a little more clear if it took the vector as an argument?
- Benjamin Mahler
On Jan. 3, 2020, 2:12 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71864/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2020, 2:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-10023 and MESOS-10056
> https://issues.apache.org/jira/browse/MESOS-10023
> https://issues.apache.org/jira/browse/MESOS-10056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> NOTE: This patch also partially addresses MESOS-9562 issue
> by modifying the logic of authorizing UNRESERVE operations.
> Now, if some reservations have no principal, both authorization of
> UNRESERVE_RESOURCES for ANY object and authorizations for unreserving
> all reservations that have principals will be requested.
>
>
> Diffs
> -----
>
> src/master/authorization.hpp PRE-CREATION
> src/master/authorization.cpp PRE-CREATION
> src/master/http.cpp 72587bf054e413402ebf4c6ff8060f7ca8ffcf1b
> src/master/master.hpp f97b085ae908278731acd326df68f9f381f09483
> src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869
>
>
> Diff: https://reviews.apache.org/r/71864/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71864: Moved creating authorization Object out of
`Master::authorize*reserve`.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71864/
-----------------------------------------------------------
(Updated Jan. 3, 2020, 2:12 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Changes
-------
Fixed formatting in master.cpp
Bugs: MESOS-10023 and MESOS-10056
https://issues.apache.org/jira/browse/MESOS-10023
https://issues.apache.org/jira/browse/MESOS-10056
Repository: mesos
Description
-------
NOTE: This patch also partially addresses MESOS-9562 issue
by modifying the logic of authorizing UNRESERVE operations.
Now, if some reservations have no principal, both authorization of
UNRESERVE_RESOURCES for ANY object and authorizations for unreserving
all reservations that have principals will be requested.
Diffs (updated)
-----
src/master/authorization.hpp PRE-CREATION
src/master/authorization.cpp PRE-CREATION
src/master/http.cpp 72587bf054e413402ebf4c6ff8060f7ca8ffcf1b
src/master/master.hpp f97b085ae908278731acd326df68f9f381f09483
src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869
Diff: https://reviews.apache.org/r/71864/diff/3/
Changes: https://reviews.apache.org/r/71864/diff/2-3/
Testing
-------
Thanks,
Andrei Sekretenko