You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/08 19:16:29 UTC

[GitHub] [tvm] masahi commented on pull request #7056: [TOPI] GPU scatter 1D via sorting based approach

masahi commented on pull request #7056:
URL: https://github.com/apache/tvm/pull/7056#issuecomment-740883003


   > Looks great! Just to clarify, this can handle repeated indices right?
   
   @tkonolige Yes definitely (that's the whole point!!). Repeated indices are grouped together by sorting, and only the last one can scatter its update to the output. The result should always be identical with the current scatter 1D and our numpy reference used in the tests. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org