You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "jnturton (via GitHub)" <gi...@apache.org> on 2023/04/03 14:30:35 UTC
[PR] DRILL-8420: Remove Guava shading and patching, and the conjars repo (drill)
jnturton opened a new pull request, #2786:
URL: https://github.com/apache/drill/pull/2786
# [DRILL-8420](https://issues.apache.org/jira/browse/DRILL-8420): Remove Guava shading and patching, and the conjars repo
## Description
- Remove shaded Guava.
- Drop conjars repository.
- Drop Guava patches.
- Upgrade guava to 31.1-jre.
- Upgrade parquet to 1.12.3 and parquet-format to 2.9.0.
- Move Splunk Maven repository declaration to contrib/storage-splunk/pom.xml.
## Documentation
N/A
## Testing
Existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2786:
URL: https://github.com/apache/drill/pull/2786#issuecomment-1498616790
@cgivre
> Thanks for this. Aside from imports, which files were actually modified and I'll do a review?
Yes, I'll split the import statement changes into a separate commit.
> Do we want to add this to back port to stable?
I don't think so. It's not a fix and it definitely carries a risk of breakage with it. Currently the Hadoop 2 build is broken because Drill's Guava patches (but not shading) are still needed in that case so I'll set the PR to draft for the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2786:
URL: https://github.com/apache/drill/pull/2786#issuecomment-1691559682
@jnturton Is this PR still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2786:
URL: https://github.com/apache/drill/pull/2786#issuecomment-1497991025
Do we want to add this to back port to stable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton closed pull request #2786: DRILL-8420: Remove Guava shading and patching
URL: https://github.com/apache/drill/pull/2786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2786:
URL: https://github.com/apache/drill/pull/2786#issuecomment-1497990433
@jnturton Thanks for this. Aside from imports, which files were actually modified and I'll do a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2786:
URL: https://github.com/apache/drill/pull/2786#issuecomment-1691627763
> @jnturton Is this PR still relevant?
Yes, I'm going to resurrect it after all the other clean up and upgrade PRs are in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org