You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/02/06 05:32:49 UTC
Review Request: Fix download file testcase build error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9319/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
GCC 4.7 implements C++11's stricter type narrowing rules in
initialization lists. Mangle test cast to comply.
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
src/tests/files_tests.cpp 84e1d6a
Diff: https://reviews.apache.org/r/9319/diff/
Testing
-------
make check passes
Thanks,
David Mackey
Re: Review Request: Fix download file testcase build error
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9319/#review16197
-----------------------------------------------------------
src/tests/files_tests.cpp
<https://reviews.apache.org/r/9319/#comment34629>
We actually, do leave 2 lines between outer functions/classes.
- Vinod Kone
On Feb. 6, 2013, 4:32 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9319/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:32 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> GCC 4.7 implements C++11's stricter type narrowing rules in
> initialization lists. Mangle test cast to comply.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 84e1d6a
>
> Diff: https://reviews.apache.org/r/9319/diff/
>
>
> Testing
> -------
>
> make check passes
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Fix download file testcase build error
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9319/#review16164
-----------------------------------------------------------
This isn't very C++-esque in its workaround. I'm open to suggestions.
- David Mackey
On Feb. 6, 2013, 4:32 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9319/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:32 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> GCC 4.7 implements C++11's stricter type narrowing rules in
> initialization lists. Mangle test cast to comply.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 84e1d6a
>
> Diff: https://reviews.apache.org/r/9319/diff/
>
>
> Testing
> -------
>
> make check passes
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Fix download file testcase build error
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9319/#review16209
-----------------------------------------------------------
src/tests/files_tests.cpp
<https://reviews.apache.org/r/9319/#comment34645>
We put a space between cast and expression.
- Benjamin Hindman
On Feb. 6, 2013, 4:32 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9319/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:32 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> GCC 4.7 implements C++11's stricter type narrowing rules in
> initialization lists. Mangle test cast to comply.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 84e1d6a
>
> Diff: https://reviews.apache.org/r/9319/diff/
>
>
> Testing
> -------
>
> make check passes
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Fix download file testcase build error
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9319/#review16241
-----------------------------------------------------------
Ship it!
- Ben Mahler
On Feb. 6, 2013, 11:41 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9319/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 11:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> GCC 4.7 implements C++11's stricter type narrowing rules in
> initialization lists. Mangle test cast to comply.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 84e1d6a
>
> Diff: https://reviews.apache.org/r/9319/diff/
>
>
> Testing
> -------
>
> make check passes
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Fix download file testcase build error
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9319/#review16226
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 6, 2013, 11:41 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9319/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 11:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> GCC 4.7 implements C++11's stricter type narrowing rules in
> initialization lists. Mangle test cast to comply.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 84e1d6a
>
> Diff: https://reviews.apache.org/r/9319/diff/
>
>
> Testing
> -------
>
> make check passes
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Fix download file testcase build error
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9319/
-----------------------------------------------------------
(Updated Feb. 6, 2013, 11:41 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Update patch to address style issues.
Description
-------
GCC 4.7 implements C++11's stricter type narrowing rules in
initialization lists. Mangle test cast to comply.
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs (updated)
-----
src/tests/files_tests.cpp 84e1d6a
Diff: https://reviews.apache.org/r/9319/diff/
Testing
-------
make check passes
Thanks,
David Mackey