You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Raghotham Murthy (JIRA)" <ji...@apache.org> on 2008/12/11 02:28:44 UTC

[jira] Created: (HIVE-158) table aliases dont work for sampled tables in joins

table aliases dont work for sampled tables in joins
---------------------------------------------------

                 Key: HIVE-158
                 URL: https://issues.apache.org/jira/browse/HIVE-158
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.19.0
            Reporter: Raghotham Murthy
            Assignee: Raghotham Murthy
             Fix For: 0.19.0


The following query:

FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;

results in the error:

ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656849#action_12656849 ] 

Namit Jain commented on HIVE-158:
---------------------------------

The sample operator created is not begin added to the hashmap - line 3549 SemanticAnalyzer.java
You have to add this.

I am forgetting the exact test-case. do you remember the scenario which we were debugging last week ?

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.3.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-158:
----------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

HIVE-158. Make table aliases work for sampled tables in joins. (Raghotham Murthy via zshao)

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.3.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghotham Murthy updated HIVE-158:
----------------------------------

    Attachment: hive-158.patch

When there is a TABLESAMPLE clause, the alias is not the second child of the join node (its the last child).

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657112#action_12657112 ] 

Namit Jain commented on HIVE-158:
---------------------------------

looked at the code more carefully - you are right - we dont need to to put in the hashmap, we are already doing it.
The changes look fine to me.

+1


> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.3.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657215#action_12657215 ] 

Zheng Shao commented on HIVE-158:
---------------------------------

Committed revision 727211.

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.3.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655459#action_12655459 ] 

Zheng Shao commented on HIVE-158:
---------------------------------

Can you add a test case?


> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghotham Murthy updated HIVE-158:
----------------------------------

    Attachment: hive-158.3.patch

Changed example so that it passes with both hadoop 17 and 20.

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.3.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655474#action_12655474 ] 

Ashish Thusoo commented on HIVE-158:
------------------------------------

diff looks good to me.

Please do run this with both -Dhadoop.version="0.19.0" and -Dhadoop.version="0.17.0" to make sure that the diff still holds and the ordering does not screw up things.

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-158:
--------------------------------

    Fix Version/s: 0.3.0
                       (was: 0.6.0)

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.3.0
>
>         Attachments: hive-158.2.patch, hive-158.3.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghotham Murthy updated HIVE-158:
----------------------------------

    Attachment: hive-158.2.patch

Missed doing svn add on the tests. done now.

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-158) table aliases dont work for sampled tables in joins

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghotham Murthy updated HIVE-158:
----------------------------------

    Status: Patch Available  (was: Open)

> table aliases dont work for sampled tables in joins
> ---------------------------------------------------
>
>                 Key: HIVE-158
>                 URL: https://issues.apache.org/jira/browse/HIVE-158
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.19.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.19.0
>
>         Attachments: hive-158.2.patch, hive-158.patch
>
>
> The following query:
> FROM table1 TABLESAMPLE (BUCKET 1 OUT OF 512 ON col1) a JOIN table2 b ON (a.j1 = b.j2)  SELECT  a.col1, a.j1, b.j2;
> results in the error:
> ERROR ql.Driver (SessionState.java:printError(263)) - FAILED: Error in semantic analysis: line 1:88 Invalid Table Alias a

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.