[jira] [Commented] (KAFKA-1714) more better bootstrapping of the gradle-wrapper.jar

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720454#comment-16720454 ] 

ASF GitHub Bot commented on KAFKA-1714:
---------------------------------------

granthenke opened a new pull request #6031: KAFKA-1714: Fix gradle wrapper bootstrapping
URL: https://github.com/apache/kafka/pull/6031
 
 
   Given we need to follow the Apache rule of not checking
   any binaries into the source code, Kafka has always had
   a bit of a tricky Gradle bootstrap.
   Using ./gradlew as users expect doesn’t work and a
   local and compatible version of Gradle was required to
   generate the wrapper first.
   
   This patch changes the behavior of the wrapper task to
   instead generate a gradlew script that can bootstrap the
   jar itself. Additionally it adds a license, removes the bat
   script, and handles retries.
   
   The documentation in the readme was also updated.
   
   Going forward patches that upgrade gradle should run
   `gradle wrapper` before checking in the change.
   
   With this change users using ./gradlew can be sure they
   are always building with the correct version of Gradle.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> more better bootstrapping of the gradle-wrapper.jar 
> ----------------------------------------------------
>
>                 Key: KAFKA-1714
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1714
>             Project: Kafka
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.8.2.0
>            Reporter: Joe Stein
>            Assignee: Grant Henke
>            Priority: Major
>
> From https://issues.apache.org/jira/browse/KAFKA-1490 we moved out the gradle-wrapper.jar for our source maintenance. This makes builds for folks coming in the first step somewhat problematic.  A bootstrap step is required if this could be somehow incorporated that would be great.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)