[GitHub] isunjin commented on a change in pull request #6780: [FLINK-9932] [runtime] fix slot leak when task executor offer slot to job master timeout

[GitBox <gi...@apache.org>]

isunjin commented on a change in pull request #6780: [FLINK-9932] [runtime] fix slot leak when task executor offer slot to job master timeout
URL: https://github.com/apache/flink/pull/6780#discussion_r222842321
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ##########
 @@ -1076,6 +1076,19 @@ private void offerSlotsToJobManager(final JobID jobId) {
 							if (throwable instanceof TimeoutException) {
 								log.info("Slot offering to JobManager did not finish in time. Retrying the slot offering.");
 								// We ran into a timeout. Try again.
+								for (SlotOffer offer : reservedSlots) {
+									try {
+										if (!taskSlotTable.markSlotInactive(offer.getAllocationId(), taskManagerConfiguration.getTimeout())) {
+											// the slot is either free or releasing at the moment
+											final String message = "Could not mark slot " + jobId + " active.";
 
 Review comment:
   merge the log to a single line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services