[GitHub] [tinkerpop] kenhuuu commented on pull request #1768: TINKERPOP-2765 Fix concurrency issue during script translation in the GremlinGroovyScriptEngine.

[GitBox <gi...@apache.org>]

kenhuuu commented on PR #1768:
URL: https://github.com/apache/tinkerpop/pull/1768#issuecomment-1199841186

   > Do you feel like this is just a patch for the stated problem in the JIRA? Would it be better if the translator were just made to be thread-safe:
   > 
   > https://issues.apache.org/jira/browse/TINKERPOP-2675
   > 
   > I'm not against merging this as it is to solve the problem, but i'm curious about the bigger issue of general thread-safety and whether or not it would make sense to refactor as TINKERPOP-2675 suggests or if your opinion would be to leave that all as it is.
   
   This is something that I thought about when investigating the fix, but I decided on making this simple patch so that it could be merged into 3.5-dev. I think it does make more sense to refactor the translators but that would likely require a breaking change so I thought it wasn't something we would want to do for 3.5-dev.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org