[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on a change in pull request #688: (ios): allow to set "preferredContentMode"

[GitBox <gi...@apache.org>]

NiklasMerz commented on a change in pull request #688:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/688#discussion_r435802162



##########
File path: README.md
##########
@@ -168,6 +168,16 @@ At the moment the only supported target in OSX is `_system`.
 
 `_blank` and `_self` targets are not yet implemented and are ignored silently. Pull requests and patches to get these to work are greatly appreciated.
 
+### iOS Quirks
+
+Since iOS 13 iPads try to adapt their content mode / user agent for the optimal browsing experience. This may result in iPads having their user agent set to `Macintosh`. You can change this with the `PreferredContentMode` preference in "config.xml".

Review comment:
       ```suggestion
   Since the introduction of iPadOS 13, iPads try to adapt their content mode / user agent for the optimal browsing experience. This may result in iPads having their user agent set to Macintosh making it hard to detect them as mobile devices using user agent string sniffing. You can change this with the PreferredContentMode preference in "config.xml".
   ```
   
   Sounds good to me. However I would try to avoid naming iPadOS an iOS fork.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org