[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6331: NIFI-10380 ListDropbox processor

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6331:
URL: https://github.com/apache/nifi/pull/6331#discussion_r964055714


##########
nifi-nar-bundles/nifi-dropbox-bundle/nifi-dropbox-services-api/src/main/java/org/apache/nifi/dropbox/credentials/service/DropboxCredentialService.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.dropbox.credentials.service;
+
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.controller.ControllerService;
+import org.apache.nifi.processor.exception.ProcessException;
+
+/**
+ * DropboxCredentialService interface to support getting Dropbox credentials (app key, app secret, access token, refresh token)
+ *
+ *
+ * @see <a href="https://www.dropbox.com/developers/reference/getting-started">Dropbox Developers Getting Started</a>
+ * @see <a href="https://dropbox.github.io/dropbox-sdk-java/api-docs/v4.0.0/com/dropbox/core/oauth/DbxCredential.html">DbxCredential</a>
+ */
+@Tags({"dropbox", "credentials", "auth", "session"})
+@CapabilityDescription("Provides DropboxCredentialDetails.")
+public interface DropboxCredentialService extends ControllerService {
+    /**
+     * Get Dropbox credentials
+     * @return  DropboxCredentialDetails object which contains app key, app secret, access and refresh tokens for authorizing
+     * requests on the Dropbox platform.
+     * @throws ProcessException process exception in case there is problem in getting credentials
+     */
+    DropboxCredentialDetails getDropboxCredential() throws ProcessException;

Review Comment:
   The `ProcessException` declaration should be removed because it is a subclass of `RuntimeException`, not a checked exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org