[GitHub] [incubator-superset] ktmud edited a comment on pull request #10070: fix: use custom int parsing over flask int parsing in sqllab queries endpoint

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #10070:
URL: https://github.com/apache/incubator-superset/pull/10070#issuecomment-645105007


   Shouldn't the endpoint accept `float` anyway though? 
   
   ```python
       @expose("/queries/<float:last_updated_ms>")
       def queries(self, last_updated_ms: float) -> FlaskResponse:
   ```
   
   Fraction milliseconds seems legit.
   
   And it also kind of makes sense for `/queries/abc` to return 404...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org