You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/12 16:59:00 UTC
[GitHub] [beam] rohdesamuel opened a new pull request #11109: [BEAM-8335]
Final PR to merge the InteractiveBeam feature branch
rohdesamuel opened a new pull request #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109
Final PR to merge everything from the InteractiveBeam feature branch
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on a change in pull request #11109:
[BEAM-8335] Final PR to merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#discussion_r391981709
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -314,6 +327,26 @@ def show(*pcolls, **configs):
bcj.attempt_to_run_background_caching_job(
runner, user_pipeline, user_pipeline.options)
+ pcolls = set(pcolls)
+ computed_pcolls = set()
+ for pcoll in pcolls:
+ if pcoll in ie.current_env().computed_pcollections:
Review comment:
so for streaming pipelines that don't cache data, this will never finish. is that correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on a change in pull request #11109:
[BEAM-8335] Final PR to merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#discussion_r391971287
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -314,6 +327,26 @@ def show(*pcolls, **configs):
bcj.attempt_to_run_background_caching_job(
runner, user_pipeline, user_pipeline.options)
+ pcolls = set(pcolls)
+ computed_pcolls = set()
+ for pcoll in pcolls:
+ if pcoll in ie.current_env().computed_pcollections:
Review comment:
@KevinGG @rohdesamuel
just for curiosity, how does a pcollection count as computed in streaming without source caching?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] KevinGG commented on a change in pull request #11109:
[BEAM-8335] Final PR to merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#discussion_r391973438
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -314,6 +327,26 @@ def show(*pcolls, **configs):
bcj.attempt_to_run_background_caching_job(
runner, user_pipeline, user_pipeline.options)
+ pcolls = set(pcolls)
+ computed_pcolls = set()
+ for pcoll in pcolls:
+ if pcoll in ie.current_env().computed_pcollections:
Review comment:
All PCollections in the pipeline that is being executed will be marked as computed once a job (main job or background caching job) completes.
So it looks like this:
pcoll_a, pcoll_b belongs to pipeline
pipeline runs into job, returns a pipeline result (main job) or a BackgroundCachingJob (backgroun caching job).
Say pcoll_a and pcoll_b are not depending on each other, and the user invokes `show(pcoll_a)`.
A pipeline fragment that only contributes to pcoll_a will be executed.
Once pipeline result is in a successful state or BackgroundCachingJob.is_done(), pcoll_a is marked as computed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11109: [BEAM-8335] Final PR to
merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#issuecomment-598484926
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11109: [BEAM-8335] Final PR to
merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#issuecomment-598958588
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11109: [BEAM-8335] Final PR to
merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#issuecomment-598379198
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11109: [BEAM-8335] Final PR to
merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#issuecomment-598955515
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem merged pull request #11109: [BEAM-8335] Final PR to
merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11109: [BEAM-8335] Final PR to
merge the InteractiveBeam feature branch
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#issuecomment-598430221
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services