You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/10 22:03:33 UTC
[GitHub] [openwhisk-wskdeploy] huydoan2 opened a new pull request #1101: Migrate to using Go Module to manage dependencies
huydoan2 opened a new pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101
Besides using Go Module (adding go.mod and go.sum), there are several changes:
1. Upgraded Go version to 1.14 alongside with other packages.
2. Modified unit tests to accommodate changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] huydoan2 commented on pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
huydoan2 commented on pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#issuecomment-674118544
Thank you, all.
@upgle We will need to clean up the doc and the Makefile in a separate PR :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows merged pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
mrutkows merged pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#issuecomment-673598619
@style95 Hi Dom, could you and colleagues (who recently showed wskdeploy IDE plugins) please review so we make sure we are not going to break you if we move to merge. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] rabbah commented on a change in pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#discussion_r469372684
##########
File path: tests/dat/manifest_data_compose_actions_for_limits.yaml
##########
@@ -21,7 +21,6 @@ packages:
hello1:
function: ../src/integration/helloworld/actions/hello.js
limits:
- timeout: 1
timeout: 600000
Review comment:
Should this be 60000 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#discussion_r469574129
##########
File path: tests/dat/manifest_data_compose_actions_for_limits.yaml
##########
@@ -21,7 +21,6 @@ packages:
hello1:
function: ../src/integration/helloworld/actions/hello.js
limits:
- timeout: 1
timeout: 600000
Review comment:
The value was not intended to be 60 seconds... just testing input matches output against some larger (max) value. Here 10 minutes...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] KeonHee commented on pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
KeonHee commented on pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#issuecomment-673857975
@mrutkows @upgle Thanks for noti & @huydoan2 Thanks for your contribution :)
It works well with Jetbrain plugin too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#issuecomment-671625726
Appreciate your work on this Huy... hopefully, this a will address the long-standing desire to use go mod as referenced in this issue: https://github.com/apache/openwhisk-wskdeploy/issues/1082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#discussion_r469574129
##########
File path: tests/dat/manifest_data_compose_actions_for_limits.yaml
##########
@@ -21,7 +21,6 @@ packages:
hello1:
function: ../src/integration/helloworld/actions/hello.js
limits:
- timeout: 1
timeout: 600000
Review comment:
The value was not intended to be 60 seconds... just testing input matches output against some larger (max) value. Here 10 minutes... The current (default) doc. max is 300000; we could change this, but this is a parser test (no validation is performed at this phase).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] huydoan2 commented on a change in pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
huydoan2 commented on a change in pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#discussion_r469377875
##########
File path: tests/dat/manifest_data_compose_actions_for_limits.yaml
##########
@@ -21,7 +21,6 @@ packages:
hello1:
function: ../src/integration/helloworld/actions/hello.js
limits:
- timeout: 1
timeout: 600000
Review comment:
Not sure. I didn't change that value. Additionally, that test file is used in parsing tests so the values may not matter much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] upgle commented on pull request #1101: Migrate to using Go Module to manage dependencies
Posted by GitBox <gi...@apache.org>.
upgle commented on pull request #1101:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1101#issuecomment-673846948
Thank you for your contribution 🎉
Could you please update the README.md? Some contents need to be modified for `go mod`.
https://github.com/apache/openwhisk-wskdeploy#developers-should-use-go-deps-and-go-build-not-go-get
And I've checked there is no issue for VSCode openwhisk plugin.
@KeonHee Could you check it for Jetbrains extension?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org