[GitHub] [incubator-doris] imay commented on a change in pull request #2154: Add date_add/sub in fe to support partition prune

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2154: Add date_add/sub in fe to support partition prune
URL: https://github.com/apache/incubator-doris/pull/2154#discussion_r343595186
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java
 ##########
 @@ -542,13 +542,49 @@ private static DateTimeFormatterBuilder formatBuilder(String pattern) throws Ana
         return builder;
     }
 
-    public DateLiteral plusDays(int day) throws AnalysisException {
+    public enum PlusType {
+        YEAR,
+        MONTH,
+        DAY,
+        HOUR,
+        MINUTE,
+        SECOND
+    }
+
+    public DateLiteral plus(int interval, PlusType plusType) throws AnalysisException{
         LocalDateTime dateTime;
+        DateTimeFormatter formatter = null;
         if (type == Type.DATE) {
-            dateTime = DATE_FORMATTER.parseLocalDateTime(getStringValue()).plusDays(day);                                        
+            formatter = DATE_FORMATTER;
+        } else if (type == Type.DATETIME){
+            formatter = DATE_TIME_FORMATTER;
         } else {
-            dateTime = DATE_TIME_FORMATTER.parseLocalDateTime(getStringValue()).plusDays(day);
+            throw new AnalysisException("Not support date literal type");
         }
+
+         switch (plusType) {
+             case YEAR:
 
 Review comment:
   ```suggestion
            case YEAR:
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org