You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "tuxji (via GitHub)" <gi...@apache.org> on 2023/02/24 18:19:25 UTC

[GitHub] [daffodil] tuxji commented on a diff in pull request #972: Update occursIndex to skip absent elements

tuxji commented on code in PR #972:
URL: https://github.com/apache/daffodil/pull/972#discussion_r1117444383


##########
daffodil-test/src/test/scala/org/apache/daffodil/usertests/TestSepTests.scala:
##########
@@ -70,6 +70,8 @@ class TestSepTests {
   @Test def test_sep_ssp_never_5(): Unit = { runner.runOneTest("test_sep_ssp_never_5") }
 
   // DAFFODIL-2791
-  @Test def test_treatAsMissing_occursIndex(): Unit = { runner.runOneTest("test_treatAsMissing_occursIndex") }

Review Comment:
   I'm using a laptop screen since I'm away from both home and office now, so I see only this much of the line and I would have to use the horizontal scrollbar to see the rest of the line (my browser is zoomed to 100%):
   
   ```scala
     @Test def test_treatAsMissing_occursIndex(): Unit = { runner.runOneTest("test_treatAsMissing_occursI
   ```
   
   BTW, I checked and found out if I increase maxColumn to 100, sbt scalafmtCheckAll fails and scalafmtAll reformats a bunch of files to re-join some files that had been split before.  Any time we change the allowed length, we'll reformat some files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org