You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/09 22:57:49 UTC
[GitHub] [gobblin] Will-Lo opened a new pull request #3307: [GOBBLIN-1467] Add check to verify gradle dependencies
Will-Lo opened a new pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Add check for github actions to verify transitive dependencies in gradle, so that errors will surface sooner.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
Will-Lo commented on pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#issuecomment-863618480
I've been using the assemble command to locally fix some of these issues so I think we can at least shorten time to detection of failures. @autumnust
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] aplex commented on a change in pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
aplex commented on a change in pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#discussion_r649409189
##########
File path: .github/workflows/build_and_test.yaml
##########
@@ -49,6 +49,9 @@ jobs:
# Only rebuild cache if build.gradle is changed
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
+ - name: Verify Dependencies
+ run: |
+ eval ./gradlew assemble
Review comment:
"gradle build" already includes "gradle assemble" - https://stackoverflow.com/questions/44185165/what-are-the-differences-between-gradle-assemble-and-gradle-build-tasks
So, is this PR about providing feedback faster than "gradle build" command, or is it more about trying to catch problems that "gradle build" would not catch?
If it's about providing faster feedback compared to "Build repository", then do you see a significant performance improvement locally in "gradle clean assemble" vs "gradle clean build -x ...." ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] aplex commented on a change in pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
aplex commented on a change in pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#discussion_r649409189
##########
File path: .github/workflows/build_and_test.yaml
##########
@@ -49,6 +49,9 @@ jobs:
# Only rebuild cache if build.gradle is changed
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
+ - name: Verify Dependencies
+ run: |
+ eval ./gradlew assemble
Review comment:
"gradle build" already includes "gradle assemble" - https://stackoverflow.com/questions/44185165/what-are-the-differences-between-gradle-assemble-and-gradle-build-tasks
So, is this PR about providing feedback faster than "gradle build" command, or is it more about trying to catch problems that "gradle build" would not catch?
If it's about providing faster feedback compared to "Build repository", then do you a significant performance improvement locally in "gradle clean assemble" vs "gradle clean build -x ...." ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
Will-Lo commented on pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#issuecomment-858843367
@autumnust @sv2000 Please take a look, this should catch some ELR failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on a change in pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
Will-Lo commented on a change in pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#discussion_r652128710
##########
File path: .github/workflows/build_and_test.yaml
##########
@@ -49,6 +49,9 @@ jobs:
# Only rebuild cache if build.gradle is changed
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
+ - name: Verify Dependencies
+ run: |
+ eval ./gradlew assemble
Review comment:
The dependency problems exist in the main code, I think the tests will compile in the testing step so it should still be caught by the pipeline eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] aplex commented on a change in pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
aplex commented on a change in pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#discussion_r652006580
##########
File path: .github/workflows/build_and_test.yaml
##########
@@ -49,6 +49,9 @@ jobs:
# Only rebuild cache if build.gradle is changed
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
+ - name: Verify Dependencies
+ run: |
+ eval ./gradlew assemble
Review comment:
I see that we skip test on the normal build below. I think that will also skip compilation and dependency resolution for test code. We can tell gradle to compile tests but not run them yet like this - https://stackoverflow.com/questions/43638697/gradle-compile-tests-but-do-not-run-them
Did we see those dependency problems in test or in a main code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on a change in pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
Will-Lo commented on a change in pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#discussion_r651998293
##########
File path: .github/workflows/build_and_test.yaml
##########
@@ -49,6 +49,9 @@ jobs:
# Only rebuild cache if build.gradle is changed
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
+ - name: Verify Dependencies
+ run: |
+ eval ./gradlew assemble
Review comment:
@aplex This might be a design issue with how I did the pipeline, but I also added some caching on the build step to shorten build times. I think it ends up caching dependencies so transitive dependency issues don't get detected by the pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] autumnust merged pull request #3307: [GOBBLIN-1467] Add check to verify transitive gradle dependencies
Posted by GitBox <gi...@apache.org>.
autumnust merged pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org