You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by "Maxim Solodovnik (JIRA)" <ji...@apache.org> on 2016/08/28 15:51:21 UTC
[jira] [Resolved] (OPENMEETINGS-1460) Application.ONLINE_USERS does
not reflect changes to Client instances
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maxim Solodovnik resolved OPENMEETINGS-1460.
--------------------------------------------
Resolution: Fixed
Assignee: Maxim Solodovnik (was: SebastianWagner)
Fix Version/s: 4.0.0
3.1.3
Admin panel is updated as expected
> Application.ONLINE_USERS does not reflect changes to Client instances
> ---------------------------------------------------------------------
>
> Key: OPENMEETINGS-1460
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1460
> Project: Openmeetings
> Issue Type: Bug
> Components: HTML5
> Affects Versions: 3.2.0
> Reporter: SebastianWagner
> Assignee: Maxim Solodovnik
> Fix For: 3.1.3, 3.2.0, 4.0.0
>
>
> When a client exits a room the method
> Application::public static Client removeClientFromRoom(Client c)
> gets called. It correctly removes the client from Applications.ROOMS and it also set c.setRoomId(null);
> But if you iterate in the same method afterward through the Application.ONLINE_USERS, the roomid for this uid is still set.
> I have added this code into the method:
> ...
> c.setRoomId(null);
> for (Client cl : ONLINE_USERS.values()) {
> log.debug("ONLINE_USERS: {} classHash: {}", cl.toString(), cl.hashCode());
> }
> In my examplethe UID = 2bbc0a00-bb7e-4bbf-875e-c5f0fbef798f, has leaves the roomId 7. The roomid is set to null, but iterating through the ONLINE_USERS still shows:
> Client [uid=2bbc0a00-bb7e-4bbf-875e-c5f0fbef798f, sessionId=6270DCAD7668BBFE2C0C341750DEFBDA, pageId=6, userId=3, roomId=7, rights=[], activities=[], connectedSince=Sat Aug 27 16:28:04 NZST 2016]
> => rommid = 7
> Example log:
> DEBUG 08-27 16:28:47.762 o.a.o.w.a.Application:332 [http-nio-0.0.0.0-5080-exec-1] - Removing online room client: 2bbc0a00-bb7e-4bbf-875e-c5f0fbef798f, room: 7 classHash: -897546578
> DEBUG 08-27 16:28:47.763 o.a.o.w.a.Application:346 [http-nio-0.0.0.0-5080-exec-1] - Cleaning up client: 2bbc0a00-bb7e-4bbf-875e-c5f0fbef798f, room: 7
> DEBUG 08-27 16:28:47.763 o.a.o.w.a.Application:355 [http-nio-0.0.0.0-5080-exec-1] - ONLINE_USERS: Client [uid=42941ebc-c396-4a5a-8856-b312f303d794, sessionId=4EAEDCBA8BF73485F72236C556CA373C, pageId=2, userId=1, roomId=null, rights=[], activities=[], connectedSince=Sat Aug 27 16:27:48 NZST 2016] classHash: 1238805733
> DEBUG 08-27 16:28:47.763 o.a.o.w.a.Application:355 [http-nio-0.0.0.0-5080-exec-1] - ONLINE_USERS: Client [uid=2bbc0a00-bb7e-4bbf-875e-c5f0fbef798f, sessionId=6270DCAD7668BBFE2C0C341750DEFBDA, pageId=6, userId=3, roomId=7, rights=[], activities=[], connectedSince=Sat Aug 27 16:28:04 NZST 2016] classHash: -897546578
> DEBUG 08-27 16:28:47.764 o.a.o.w.a.Application:355 [http-nio-0.0.0.0-5080-exec-1] - ONLINE_USERS: Client [uid=69deb6a3-ea3f-47d9-b33e-c0c85700ceeb, sessionId=90340C30D6D32BB8E2D44579EC33E9C0, pageId=6, userId=2, roomId=7, rights=[moderator], activities=[], connectedSince=Sat Aug 27 16:27:58 NZST 2016] classHash: 1731054890
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)