You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 10:37:02 UTC
[I] Add reader state class to remove state from the reader context [hudi]
hudi-bot opened a new issue, #16605:
URL: https://github.com/apache/hudi/issues/16605
Reader context is getting cluttered with state. Create new class to contain all that so we can keep the reader context a bit more simple
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-8170
- Type: Improvement
- Epic: https://issues.apache.org/jira/browse/HUDI-6243
- Fix version(s):
- 1.1.0
---
## Comments
23/Oct/24 06:30;yihua;In HUDI-8203 (https://github.com/apache/hudi/pull/11943), record merger is made `Option<HoodieRecordMerger>` (see https://github.com/apache/hudi/pull/11943#discussion_r1805544464). We should make it final so that there is no chance of hitting NPE or merge implementation class not set.;;;
---
23/Oct/24 06:52;yihua;Another improvement: we should get rid of the call `readerContext.setRecordMerger(readerContext.getRecordMerger(...))` and only have `setRecordMerger` for simplicity (see details in https://github.com/apache/hudi/pull/11943#discussion_r1805660051).;;;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add reader state class to remove state from the reader context [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on issue #16605:
URL: https://github.com/apache/hudi/issues/16605#issuecomment-3630130229
### Linked PR(s)
- https://github.com/apache/hudi/pull/11827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add reader state class to remove state from the reader context [hudi]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on issue #16605:
URL: https://github.com/apache/hudi/issues/16605#issuecomment-5434689807
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8170).
**Findings: not done on `master`.**
There is no `ReaderState` or `ReaderContextState` class anywhere in the tree, so the state the description wants extracted still lives directly on `HoodieReaderContext`.
Two notes on the linked PRs, since together they read misleadingly:
- **#11827** (`[HUDI-8170] Create Reader State Class to remove state from the reader context`) - this ticket's own PR - is **closed unmerged**. So the `status:pr-available` label implies a patch awaiting review when there is none.
- **#11943** (`[HUDI-8203] Make record merge mode the primary merging config`) is merged, but carries a different JIRA key - it is the PR whose review raised this, not a fix for it.
Worth pairing with #16695 (HUDI-8417), which asks for `HoodieReaderContext.setRecordMerger` to stop taking an `Option` - the same "simplify the reader context" cleanup, and both touch the same class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org