You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "garydgregory (via GitHub)" <gi...@apache.org> on 2023/04/22 13:25:42 UTC

[GitHub] [commons-io] garydgregory commented on pull request #452: Add ability to specify wait time to QueueInputStream

garydgregory commented on PR #452:
URL: https://github.com/apache/commons-io/pull/452#issuecomment-1518657241

   @maxxedev 
   TY for the PR. 
   
   I merged it and updated the code to use a builder instead of adding yet another constructor (see the rest of the code base).
   
   What feels odd is that `LinkedBlockingQueue` polls using nanoseconds and we now use milliseconds as the internal timeout, so we cannot use the most precise polling. Any thoughts on changing milliseconds to nanoseconds?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org