You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/05/05 03:05:38 UTC
[jira] Commented: (MPECLIPSE-25) Add the capability of specifying more builders
The following comment has been added to this issue:
Author: dion gillard
Created: Tue, 4 May 2004 9:04 PM
Body:
This patch looks ok to me. It would be nice if we had a test case for it, but I can apply and test if everyone is ok with it
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPECLIPSE-25&page=comments#action_19371
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPECLIPSE-25
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-25
Summary: Add the capability of specifying more builders
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Assignee:
Reporter: Miguel Griffa
Created: Mon, 3 May 2004 6:28 PM
Updated: Tue, 4 May 2004 9:04 PM
Description:
If the project uses any builder besidesd the java buidler the .project file cannot be generated. a property holding different builders and maybe natures would help solving this issue
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying
more builders
Posted by Miguel Griffa <mg...@technisys.net>.
I submited a patch that adds tests for the builders and natures,
I made the tests separated because I think that the test shuold include
some validation over the expected contents of the generated file
I don't know how to do this with jelly yet...
Miguel Griffa wrote:
> I'll go for the test case now,
> I'm sorry, but being newbie is a bit unfamiliar for me testing maven
> plugin
> I'll submit a patch for the test case if I manage to get one :)
>
> jira@codehaus.org wrote:
>
>> The following comment has been added to this issue:
>>
>> Author: dion gillard
>> Created: Tue, 4 May 2004 9:04 PM
>> Body:
>> This patch looks ok to me. It would be nice if we had a test case for
>> it, but I can apply and test if everyone is ok with it
>> ---------------------------------------------------------------------
>> View this comment:
>> http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPECLIPSE-25&page=comments#action_19371
>>
>>
>> ---------------------------------------------------------------------
>> View the issue:
>> http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPECLIPSE-25
>>
>> Here is an overview of the issue:
>> ---------------------------------------------------------------------
>> Key: MPECLIPSE-25
>> Summary: Add the capability of specifying more builders
>> Type: Improvement
>>
>> Status: Unassigned
>> Priority: Major
>>
>> Original Estimate: Unknown
>> Time Spent: Unknown
>> Remaining: Unknown
>>
>> Project: maven-eclipse-plugin
>>
>> Assignee: Reporter: Miguel Griffa
>>
>> Created: Mon, 3 May 2004 6:28 PM
>> Updated: Tue, 4 May 2004 9:04 PM
>>
>> Description:
>> If the project uses any builder besidesd the java buidler the
>> .project file cannot be generated. a property holding different
>> builders and maybe natures would help solving this issue
>>
>>
>> ---------------------------------------------------------------------
>> JIRA INFORMATION:
>> This message is automatically generated by JIRA.
>>
>> If you think it was sent incorrectly contact one of the administrators:
>> http://jira.codehaus.org/secure/Administrators.jspa
>>
>> If you want more information on JIRA, or have a bug to report see:
>> http://www.atlassian.com/software/jira
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>
>
>
--
Miguel Griffa
Software Architect
Technisys.NET "The First Digital e-nabler"
Transactional Solutions
Miami +1 305 357 8109
Madrid +34 915 726 763
Buenos Aires: +54 11 43227100
mgriffa@technisys.net
http://www.technisys.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying
more builders
Posted by Miguel Griffa <mg...@technisys.net>.
I'll go for the test case now,
I'm sorry, but being newbie is a bit unfamiliar for me testing maven plugin
I'll submit a patch for the test case if I manage to get one :)
jira@codehaus.org wrote:
>The following comment has been added to this issue:
>
> Author: dion gillard
> Created: Tue, 4 May 2004 9:04 PM
> Body:
>This patch looks ok to me. It would be nice if we had a test case for it, but I can apply and test if everyone is ok with it
>---------------------------------------------------------------------
>View this comment:
> http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPECLIPSE-25&page=comments#action_19371
>
>---------------------------------------------------------------------
>View the issue:
> http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPECLIPSE-25
>
>Here is an overview of the issue:
>---------------------------------------------------------------------
> Key: MPECLIPSE-25
> Summary: Add the capability of specifying more builders
> Type: Improvement
>
> Status: Unassigned
> Priority: Major
>
> Original Estimate: Unknown
> Time Spent: Unknown
> Remaining: Unknown
>
> Project: maven-eclipse-plugin
>
> Assignee:
> Reporter: Miguel Griffa
>
> Created: Mon, 3 May 2004 6:28 PM
> Updated: Tue, 4 May 2004 9:04 PM
>
>Description:
>If the project uses any builder besidesd the java buidler the .project file cannot be generated. a property holding different builders and maybe natures would help solving this issue
>
>
>---------------------------------------------------------------------
>JIRA INFORMATION:
>This message is automatically generated by JIRA.
>
>If you think it was sent incorrectly contact one of the administrators:
> http://jira.codehaus.org/secure/Administrators.jspa
>
>If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
--
Miguel Griffa
Software Architect
Technisys.NET "The First Digital e-nabler"
Transactional Solutions
Miami +1 305 357 8109
Madrid +34 915 726 763
Buenos Aires: +54 11 43227100
mgriffa@technisys.net
http://www.technisys.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying
more builders
Posted by Miguel Griffa <mg...@technisys.net>.
Hi
I don't think (excuse me all for giving my opinion like this being
so unknown) supporting eclipse plugins directy should be added to maven.
This would be a lot of work and little payoff. I think that the current
plugin shuold be improved to support all data for .project and
.classpath (project references, sources locations) but nothing more.
Plugins that use custom configuration files don't need anything more
that a nature or builder (they can't need something unsupported by
project description file).
On the other side, a plugin that uses a custom confuiguration file,
should support a configuration file generic enough to be on CVS and
downloaded with the rest of the project. What would be the benefit of
generating a file that could be on CVS?
property substitution and more could be done in a postGoal for eclise.
Again, sorry for speaking wo loud, but I'm a big eclipse fan and I'm
becoming a big maven fan too and, well...
Felipe Leme wrote:
> Hi all,
>
> Regardless of this patche fixing the bug or not, I think we could go a
> step further on the Eclipse project/nature/builder support. Let me
> explain better.
>
> For the case of 'less intrusive' Eclipse plugins (like Checkstyle), I
> think the patch is fine. But that is not enough for plugins that takes
> more control of your eclipse workspace - there are some plugins, for
> instance, that creates some XML files or even copy other jars in your
> project. More than that, you might want to support multiple plugins in
> your project, according to each developer preference (or budget
> limitation). Take for instance web/J2EE development. There are many
> plugins available for the task, being MyEclipseIDE and Lomboz the most
> popular ones. It would be nice if the same maven-powered project could
> be used by any of these plugins. So, in those cases, we would have
> specific goals for each plugin. Something like:
>
> maven eclipse:eclipse -> default java project
> maven eclispe:myeclipseide
> maven eclipse:lomboz
> ....and so on....
>
> We would still apply dion's patch so we can manually define our
> project builders, but when we call these new goals, the goal itself
> would know what builders/nature it must use.
>
> Another thing that would be useful is to define the web structure of
> your application (i.e., where the files are, which JARs should be in
> the libetc...) in the POM, so these plugins could create the right
> structure in place (for instance, copying the jars from $MAVEN_HOME to
> web/WEB-INF/lib). But this is not specfic to the Eclipse plug-in, it
> should be something 'maven-widely' (maybe the current POM model
> already supports it - I'm still a semi-newbie maven user, so sorry if
> it already does and I didn't know :-).
>
> Finally, once we discuss this issue and decide if it is usefull or not
> (i.e., if a new patch would be accepted/committed in), I could open a
> new bug describing it and even work on the patches (in fact, I should
> have done that already, but been too busy to - right now we are just
> using the default eclipse:eclise goal and then manually using
> MyEclipseIDE to add a web-module on the project).
>
> Regards,
>
> Felipe
>
> jira@codehaus.org wrote:
>
>> The following comment has been added to this issue:
>>
>> Author: dion gillard
>> Created: Tue, 4 May 2004 9:04 PM
>> Body:
>> This patch looks ok to me. It would be nice if we had a test case for
>> it, but I can apply and test if everyone is ok with it
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Miguel Griffa
Software Architect
Technisys.NET "The First Digital e-nabler"
Transactional Solutions
Miami +1 305 357 8109
Madrid +34 915 726 763
Buenos Aires: +54 11 43227100
mgriffa@technisys.net
http://www.technisys.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Commented: (MPECLIPSE-25) Add the capability of specifying
more builders
Posted by Felipe Leme <ma...@felipeal.net>.
Hi all,
Regardless of this patche fixing the bug or not, I think we could go a
step further on the Eclipse project/nature/builder support. Let me
explain better.
For the case of 'less intrusive' Eclipse plugins (like Checkstyle), I
think the patch is fine. But that is not enough for plugins that takes
more control of your eclipse workspace - there are some plugins, for
instance, that creates some XML files or even copy other jars in your
project. More than that, you might want to support multiple plugins in
your project, according to each developer preference (or budget
limitation). Take for instance web/J2EE development. There are many
plugins available for the task, being MyEclipseIDE and Lomboz the most
popular ones. It would be nice if the same maven-powered project could
be used by any of these plugins. So, in those cases, we would have
specific goals for each plugin. Something like:
maven eclipse:eclipse -> default java project
maven eclispe:myeclipseide
maven eclipse:lomboz
....and so on....
We would still apply dion's patch so we can manually define our project
builders, but when we call these new goals, the goal itself would know
what builders/nature it must use.
Another thing that would be useful is to define the web structure of
your application (i.e., where the files are, which JARs should be in the
libetc...) in the POM, so these plugins could create the right structure
in place (for instance, copying the jars from $MAVEN_HOME to
web/WEB-INF/lib). But this is not specfic to the Eclipse plug-in, it
should be something 'maven-widely' (maybe the current POM model already
supports it - I'm still a semi-newbie maven user, so sorry if it already
does and I didn't know :-).
Finally, once we discuss this issue and decide if it is usefull or not
(i.e., if a new patch would be accepted/committed in), I could open a
new bug describing it and even work on the patches (in fact, I should
have done that already, but been too busy to - right now we are just
using the default eclipse:eclise goal and then manually using
MyEclipseIDE to add a web-module on the project).
Regards,
Felipe
jira@codehaus.org wrote:
>The following comment has been added to this issue:
>
> Author: dion gillard
> Created: Tue, 4 May 2004 9:04 PM
> Body:
>This patch looks ok to me. It would be nice if we had a test case for it, but I can apply and test if everyone is ok with it
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org