You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/28 06:25:30 UTC
[GitHub] [beam] mouyang opened a new pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
mouyang opened a new pull request #14350:
URL: https://github.com/apache/beam/pull/14350
- toString for bqType BOOLEAN, FLOAT so that it can be picked up by BigQueryUtils.toBeamValue
- change BigQueryUtils handling of Mode.REPEATED elements because it now works with Lists, not List<Map>
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>SDK</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon">
</a>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img src="https://camo.githubusercontent.com/4565d7b7e907114e6c1d12323408bd903aa252fefed5eeab93701b05c9628a84/68747470733a2f2f63692d6265616d2e6170616368652e6f72672f6a6f622f6265616d5f507265436f6d6d69745f507974686f6e446f636b65725f43726f6e2f62616467652f69636f6e" alt="Build Status" data-canonical-src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img src="https://camo.githubusercontent.com/21afb097a5745440598bee5c59a027b140585eec871c3f3b883200610fabf722/68747470733a2f2f63692d6265616d2e6170616368652e6f72672f6a6f622f6265616d5f507265436f6d6d69745f507974686f6e446f63735f43726f6e2f62616467652f69636f6e" alt="Build Status" data-canonical-src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-840889336
What is the next step on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811088402
Tried retesting for kicks but the tests still failed. I do find it peculiar that the two failed tests compliment each other. Both are expecting a two elements with one test missing one of the two elements and the other test missing the other.
For reasons I mentioned previously regarding I'm unable to reproduce this failure locally and I will need help to resolve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811323465
# [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=h1) Report
> Merging [#14350](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=desc) (5ddb69f) into [master](https://codecov.io/gh/apache/beam/commit/b43952ca369418e6f0d6cc2d4c54f991d7aafb25?el=desc) (b43952c) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5ddb69f differs from pull request most recent head ba379d4. Consider uploading reports for the commit ba379d4 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14350 +/- ##
==========================================
- Coverage 83.45% 83.44% -0.02%
==========================================
Files 470 470
Lines 59101 59107 +6
==========================================
- Hits 49321 49320 -1
- Misses 9780 9787 +7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.37% <0.00%> (-0.38%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.73% <0.00%> (-0.26%)` | :arrow_down: |
| [...ld/srcs/sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.52% <0.00%> (ø)` | |
| [...nternal/clients/dataflow/dataflow\_v1b3\_messages.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L2RhdGFmbG93X3YxYjNfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `94.66% <0.00%> (+0.01%)` | :arrow_up: |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `73.89% <0.00%> (+0.08%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=footer). Last update [cf3f2a4...ba379d4](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-829457610
sorry about the delay. I'll look at this now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811323465
# [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=h1) Report
> Merging [#14350](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=desc) (ec9e413) into [master](https://codecov.io/gh/apache/beam/commit/7ffa53264dbeea76c8d274d066078d09dabce6a3?el=desc) (7ffa532) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ec9e413 differs from pull request most recent head b7f0b90. Consider uploading reports for the commit b7f0b90 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14350 +/- ##
==========================================
+ Coverage 83.38% 83.45% +0.06%
==========================================
Files 469 470 +1
Lines 58727 59001 +274
==========================================
+ Hits 48972 49240 +268
- Misses 9755 9761 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ld/srcs/sdks/python/apache\_beam/io/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL19faW5pdF9fLnB5) | `81.81% <0.00%> (-2.80%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.50% <0.00%> (-0.35%)` | :arrow_down: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.60% <0.00%> (-0.07%)` | :arrow_down: |
| [...build/srcs/sdks/python/apache\_beam/io/gcp/gcsio.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5) | `90.50% <0.00%> (-0.04%)` | :arrow_down: |
| [...st-suites/tox/py38/build/srcs/sdks/python/setup.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vc2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [.../srcs/sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.30% <0.00%> (ø)` | |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | `59.21% <0.00%> (ø)` | |
| [...nners/portability/fn\_api\_runner/trigger\_manager.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyaWdnZXJfbWFuYWdlci5weQ==) | `94.78% <0.00%> (ø)` | |
| [...ld/srcs/sdks/python/apache\_beam/utils/timestamp.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdGltZXN0YW1wLnB5) | `96.39% <0.00%> (+0.03%)` | :arrow_up: |
| [...build/srcs/sdks/python/apache\_beam/dataframe/io.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2lvLnB5) | `91.74% <0.00%> (+0.07%)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=footer). Last update [7ffa532...b7f0b90](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-963478716
Pinging @pabloem but maybe @TheNeuralBit has already reviewed enough if Pablo doesn't have time? Were you just asking for a check to make sure you got enough context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811569878
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-829691701
@mouyang @TheNeuralBit Thanks for the update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang removed a comment on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang removed a comment on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-812215008
merge conflicts resolved
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
ihji commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-829612744
FYI, this PR is a [blocker](https://issues.apache.org/jira/browse/BEAM-9613) for 2.30.0. Quick turnaround needed from the reviewer and the author if you want to timely cherry-pick this into 2.30.0 release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-812215171
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-812215497
Saw there were merge conflicts. Rebased to eliminate them. Running the tests again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-982851871
Folks, what are the next steps on this PR? I would be in favor of merging it, If it is reviewed enough by either @pabloem or @TheNeuralBit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamini2 commented on a change in pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
chamini2 commented on a change in pull request #14350:
URL: https://github.com/apache/beam/pull/14350#discussion_r739559850
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##########
@@ -636,7 +636,6 @@ private static Object toBeamValue(FieldType fieldType, Object jsonBQValue) {
if (jsonBQValue instanceof List) {
return ((List<Object>) jsonBQValue)
.stream()
- .map(v -> ((Map<String, Object>) v).get("v"))
.map(v -> toBeamValue(fieldType.getCollectionElementType(), v))
Review comment:
But we do not have a `Field` for it. We may need to add a null check in `toBeamValue` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811991196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit edited a comment on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
TheNeuralBit edited a comment on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811308268
oh also here: https://github.com/apache/beam/blob/ec9e41311527e1e9f38d4d325101db9eee3cbcd4/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java#L981-L993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-829624951
Hey @ihji - I don't think it makes sense for this to block 2.30.0, BEAM-9613 has been open for over a year. We should probably just remove the fix version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-829484565
> sorry about the delay. I'll look at this now...
No worries. There's no rush. My team worked around the issue for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-840915412
@aaltay awaiting feedback from @pabloem. I haven't found time to resolve the issues I've experienced in running the full test suite on my Windows machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-874804973
> @pabloem - Would you be able to review this?
+1 @pabloem how is this going? Because of the access modifiers on the methods, I need to fork this file to work around this and other BigQueryUtils issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-829651941
> FYI, this PR is a [blocker](https://issues.apache.org/jira/browse/BEAM-9613) for 2.30.0. Quick turnaround needed from the reviewer and the author if you want to timely cherry-pick this into 2.30.0 release branch.
Thanks for pointing it out. I agree with @TheNeuralBit's recommendation and removed the fix version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-881153152
> > @pabloem - Would you be able to review this?
>
> +1 @pabloem how is this going? Because of the access modifiers on the methods, I need to fork this file to work around this and other BigQueryUtils issues.
@pabloem is OOO until August. Please ping this thread in August and we can continue the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811323465
# [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=h1) Report
> Merging [#14350](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=desc) (5ddb69f) into [master](https://codecov.io/gh/apache/beam/commit/b43952ca369418e6f0d6cc2d4c54f991d7aafb25?el=desc) (b43952c) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5ddb69f differs from pull request most recent head ba379d4. Consider uploading reports for the commit ba379d4 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14350 +/- ##
==========================================
- Coverage 83.45% 83.44% -0.01%
==========================================
Files 470 470
Lines 59101 59107 +6
==========================================
+ Hits 49321 49323 +2
- Misses 9780 9784 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.37% <0.00%> (-0.38%)` | :arrow_down: |
| [...ld/srcs/sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.52% <0.00%> (ø)` | |
| [...nternal/clients/dataflow/dataflow\_v1b3\_messages.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L2RhdGFmbG93X3YxYjNfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `94.66% <0.00%> (+0.01%)` | :arrow_up: |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `73.89% <0.00%> (+0.08%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.99% <0.00%> (+0.12%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=footer). Last update [cf3f2a4...ba379d4](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-849992494
@pabloem - Would you be able to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-812232598
I took a look at the PostCommit failure (`BigQueryNestedRecordsIT.testNestedRecords`), it's another case where the expected result contains doubles, and now we're producing strings. However in this case we're using `BigqueryClient` to read the expected value directly, and it's producing the value that contains doubles.
It looks like BigqueryClient actually already has logic to convert the Strings we get from BQ into booleans and doubles: https://github.com/apache/beam/blob/5ddb69f4bd9fc281c3f401fee87232163ee09ba9/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java#L258-L259
(CC: @pabloem since it looks like you added this logic)
So maybe your [original approach](https://github.com/mouyang/beam/commit/326b291ab333c719a9f54446c34611581ea696eb) is actually correct?
If that's the case I would expect reading beam rows to fail with JSON as well as Avro, is there a test for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-991450366
What is the next step on this PR? Should we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811561722
@TheNeuralBit thanks for looking into it for me. I didn't know how to avoid vertical scroll hell previously, but I found out and posted what showed up in the below. I couldn't find anything specific to a permission error or anything specific for that matter.
In the mean time, I'll make the changes you hinted at and give it a another blind go.
<details>
<summary>Error in Test Report</summary>
org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.RuntimeException: Failed to create job with prefix beam_bq_job_LOAD_bigqueryiowritetest0testwriteavro000maouyan03282032418eff7d5e_a5734b516aaf48229aaf8a974328bcf8_1af13eb133f5d1e510c8e70fecb762c7_00001_00000, reached max retries: 3, last failed job: {
"configuration" : {
"load" : {
"createDisposition" : "CREATE_IF_NEEDED",
"destinationTable" : {
"datasetId" : "dataset-id",
"projectId" : "project-id",
"tableId" : "table-id"
},
"ignoreUnknownValues" : false,
"schemaUpdateOptions" : [ ],
"sourceFormat" : "AVRO",
"useAvroLogicalTypes" : false,
"writeDisposition" : "WRITE_EMPTY"
}
},
"jobReference" : {
"jobId" : "beam_bq_job_LOAD_bigqueryiowritetest0testwriteavro000maouyan03282032418eff7d5e_a5734b516aaf48229aaf8a974328bcf8_1af13eb133f5d1e510c8e70fecb762c7_00001_00000-2",
"projectId" : "project-id"
},
"kind" : " bigquery#job",
"status" : {
"errorResult" : { },
"state" : "FAILED"
}
}.
at org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:371)
at org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:339)
at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:219)
at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:67)
at org.apache.beam.sdk.Pipeline.run(Pipeline.java:322)
at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:398)
at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:334)
at org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOWriteTest.testWriteAvro(BigQueryIOWriteTest.java:916)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.apache.beam.sdk.testing.TestPipeline$1.evaluate(TestPipeline.java:322)
at org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOWriteTest$1$1.evaluate(BigQueryIOWriteTest.java:193)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:119)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.RuntimeException: Failed to create job with prefix beam_bq_job_LOAD_bigqueryiowritetest0testwriteavro000maouyan03282032418eff7d5e_a5734b516aaf48229aaf8a974328bcf8_1af13eb133f5d1e510c8e70fecb762c7_00001_00000, reached max retries: 3, last failed job: {
"configuration" : {
"load" : {
"createDisposition" : "CREATE_IF_NEEDED",
"destinationTable" : {
"datasetId" : "dataset-id",
"projectId" : "project-id",
"tableId" : "table-id"
},
"ignoreUnknownValues" : false,
"schemaUpdateOptions" : [ ],
"sourceFormat" : "AVRO",
"useAvroLogicalTypes" : false,
"writeDisposition" : "WRITE_EMPTY"
}
},
"jobReference" : {
"jobId" : "beam_bq_job_LOAD_bigqueryiowritetest0testwriteavro000maouyan03282032418eff7d5e_a5734b516aaf48229aaf8a974328bcf8_1af13eb133f5d1e510c8e70fecb762c7_00001_00000-2",
"projectId" : "project-id"
},
"kind" : " bigquery#job",
"status" : {
"errorResult" : { },
"state" : "FAILED"
}
}.
at org.apache.beam.sdk.io.gcp.bigquery.BigQueryHelpers$PendingJob.runJob(BigQueryHelpers.java:199)
at org.apache.beam.sdk.io.gcp.bigquery.BigQueryHelpers$PendingJobManager.waitForDone(BigQueryHelpers.java:152)
at org.apache.beam.sdk.io.gcp.bigquery.WriteTables$WriteTablesDoFn.finishBundle(WriteTables.java:285)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811307503
The problem seems to be the double values here: https://github.com/apache/beam/blob/ec9e41311527e1e9f38d4d325101db9eee3cbcd4/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java#L924 and here: https://github.com/apache/beam/blob/ec9e41311527e1e9f38d4d325101db9eee3cbcd4/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java#L929
Changing those to String literals fixes the test locally for me.
What was the underlying error for you? Is it a permissions error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-812225439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-1081833569
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811323465
# [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=h1) Report
> Merging [#14350](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=desc) (ec9e413) into [master](https://codecov.io/gh/apache/beam/commit/7ffa53264dbeea76c8d274d066078d09dabce6a3?el=desc) (7ffa532) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ec9e413 differs from pull request most recent head f530c00. Consider uploading reports for the commit f530c00 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14350 +/- ##
==========================================
+ Coverage 83.38% 83.45% +0.06%
==========================================
Files 469 470 +1
Lines 58727 59001 +274
==========================================
+ Hits 48972 49240 +268
- Misses 9755 9761 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ld/srcs/sdks/python/apache\_beam/io/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL19faW5pdF9fLnB5) | `81.81% <0.00%> (-2.80%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.50% <0.00%> (-0.35%)` | :arrow_down: |
| [...srcs/sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.60% <0.00%> (-0.07%)` | :arrow_down: |
| [...build/srcs/sdks/python/apache\_beam/io/gcp/gcsio.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5) | `90.50% <0.00%> (-0.04%)` | :arrow_down: |
| [...st-suites/tox/py38/build/srcs/sdks/python/setup.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vc2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [.../srcs/sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.30% <0.00%> (ø)` | |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | `59.21% <0.00%> (ø)` | |
| [...nners/portability/fn\_api\_runner/trigger\_manager.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyaWdnZXJfbWFuYWdlci5weQ==) | `94.78% <0.00%> (ø)` | |
| [...ld/srcs/sdks/python/apache\_beam/utils/timestamp.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdGltZXN0YW1wLnB5) | `96.39% <0.00%> (+0.03%)` | :arrow_up: |
| [...build/srcs/sdks/python/apache\_beam/dataframe/io.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2lvLnB5) | `91.74% <0.00%> (+0.07%)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=footer). Last update [7ffa532...f530c00](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-991450366
What is the next step on this PR? Should we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-812215008
merge conflicts resolved
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811323465
# [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=h1) Report
> Merging [#14350](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=desc) (ec9e413) into [master](https://codecov.io/gh/apache/beam/commit/b43952ca369418e6f0d6cc2d4c54f991d7aafb25?el=desc) (b43952c) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ec9e413 differs from pull request most recent head ba379d4. Consider uploading reports for the commit ba379d4 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14350 +/- ##
========================================
Coverage 83.45% 83.45%
========================================
Files 470 470
Lines 59101 59001 -100
========================================
- Hits 49321 49240 -81
+ Misses 9780 9761 -19
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `73.56% <0.00%> (-0.60%)` | :arrow_down: |
| [.../srcs/sdks/python/apache\_beam/typehints/schemas.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NjaGVtYXMucHk=) | `93.71% <0.00%> (-0.49%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.37% <0.00%> (-0.38%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/interactive/utils.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91dGlscy5weQ==) | `92.38% <0.00%> (-0.35%)` | :arrow_down: |
| [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `99.20% <0.00%> (-0.27%)` | :arrow_down: |
| [...38/build/srcs/sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.18%)` | :arrow_down: |
| [...d/srcs/sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `93.06% <0.00%> (-0.17%)` | :arrow_down: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `98.92% <0.00%> (-0.04%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/beam/pull/14350/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=footer). Last update [cf3f2a4...ba379d4](https://codecov.io/gh/apache/beam/pull/14350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-813437945
@TheNeuralBit honestly after seeing that, I don't know without additional context. It's clear now that BigQueryUtils and BigqueryClient duplicates some efforts. Removing the type conversions in BigqueryClient would be closer to the metal and consistent with the second approach you proposed earlier. There also no performance hit as previously feared in staying with Strings because everything starts off as a String.
I'm fine with waiting to hear back from @pabloem but the second option you proposed still looks viable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811308268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-808951531
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamini2 commented on a change in pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
chamini2 commented on a change in pull request #14350:
URL: https://github.com/apache/beam/pull/14350#discussion_r739559051
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##########
@@ -636,7 +636,6 @@ private static Object toBeamValue(FieldType fieldType, Object jsonBQValue) {
if (jsonBQValue instanceof List) {
return ((List<Object>) jsonBQValue)
.stream()
- .map(v -> ((Map<String, Object>) v).get("v"))
.map(v -> toBeamValue(fieldType.getCollectionElementType(), v))
Review comment:
Does this change account for BEAM-12863? I think we could need a way to handle it here.
The ticket reporter suggested calling `toBeamRowFieldValue` instead of `toBeamValue` directly, for it to check on null array elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-1023533056
@aaltay I haven't had a chance to do further work on this and I'm not sure when I will get the chance, but I definitely think this needs to be addressed because it's definitely a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-811053333
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mouyang commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-808955884
Any help would on the build failure would be appreciated.
I tried "retest this please" but the job failed with the same error. I'm unable to reproduce the test failures in my development environment because I can an error that says it can't even create a job in the first place.
`org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.RuntimeException: Failed to create job with prefix beam_bq_job_LOAD_bigqueryiowritetest0testwriteavro000maouyan03282032418eff7d5e_a5734b516aaf48229aaf8a974328bcf8_1af13eb133f5d1e510c8e70fecb762c7_00001_00000, reached max retries: 3, last failed job: {
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-889571660
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #14350: [BEAM-9613] fix handling of BQ BOOLEAN, FLOAT, REPEATED
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-1023573764
> @aaltay I haven't had a chance to do further work on this and I'm not sure when I will get the chance, but I definitely think this needs to be addressed because it's definitely a bug.
Thank you and I understand.
Other folks here, if one of you would be interested please pick up the PR and the jira issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org