[GitHub] [spark] MaxGekk commented on a change in pull request #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server
URL: https://github.com/apache/spark/pull/27552#discussion_r378739387
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
 ##########
 @@ -178,7 +179,12 @@ private[hive] class SparkExecuteStatementOperation(
           }
           curCol += 1
         }
-        resultRowSet.addRow(row.toArray.asInstanceOf[Array[Object]])
+        val resultRow = row.map {
 
 Review comment:
   I have to convert Java 8 classes to `java.sql.Timestamp`/`Date` for correct formatting. I cannot use `TimestampFormatter` here because the conversions to strings can be performed in `ColumnBuffer` in `hive-serde`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org