You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "danepitkin (via GitHub)" <gi...@apache.org> on 2024/07/23 21:34:23 UTC
[PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
danepitkin opened a new pull request, #43395:
URL: https://github.com/apache/arrow/pull/43395
### Rationale for this change
Now that Arrow Java has moved from Java 8 -> Java 11, we need to add `--add-opens` when running Java.
### What changes are included in this PR?
* Add `--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` to `_JAVA_OPTIONS` in archery.
### Are these changes tested?
To be verified via CI and ursabot.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246634791
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin merged PR #43395:
URL: https://github.com/apache/arrow/pull/43395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246365082
Benchmark runs are scheduled for commit 3b8b942a943bb95fb0b4ee91aed12394ce058340. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246960142
Thanks for your patience. Conbench analyzed the 2 benchmarking runs that have been run so far on PR commit 3b8b942a943bb95fb0b4ee91aed12394ce058340.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/27841115337) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246593490
@danepitkin shall we run the crossbows as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246636762
Revision: 3b8b942a943bb95fb0b4ee91aed12394ce058340
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4f8795faaf](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4f8795faaf)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/10068444837/job/27833827407)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/10068444967/job/27833826874)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10068444759/job/27833826309)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10068444750/job/27833826290)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10068444774/job/27833826261)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10068444769/job/27833826294)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10068444852/job/27833826553)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246357749
:warning: GitHub issue #43394 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246635163
Thanks @vibhatha!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246364972
@ursabot please benchmark lang=Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2249051837
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a49dbcc8bda170f48f3cc07f5453105129015db0.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/27886156751) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #43395:
URL: https://github.com/apache/arrow/pull/43395#issuecomment-2246496200
Benchmark run is successful: https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-m5-4xlarge-us-east-2/builds/5025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org