[GitHub] [hive] kasakrisz commented on a diff in pull request #4120: HIVE-27142: Map Join not working as expected when joining non-native tables with native tables

["kasakrisz (via GitHub)" <gi...@apache.org>]

kasakrisz commented on code in PR #4120:
URL: https://github.com/apache/hive/pull/4120#discussion_r1141926589


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java:
##########
@@ -167,21 +167,23 @@ public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx procCtx,
       PrunedPartitionList partList = aspCtx.getParseContext().getPrunedPartitions(tsop);
       ColumnStatsList colStatsCached = aspCtx.getParseContext().getColStatsCached(partList);
       Table table = tsop.getConf().getTableMetadata();
+      boolean skipStatsCollection = table.isNonNative() && !HiveConf.getBoolVar(aspCtx.getConf(),

Review Comment:
   I don't think skipping fetching stats is a good idea at this point. There are non-native storage formats like Iceberg which supports stats and there is an ongoing effort to use them.
   https://github.com/apache/hive/pull/4000



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org