[jira] [Created] (SPARK-2903) Spark SQL tests fail to compile due to dependency structure, misplaced test class

["Sean Owen (JIRA)" <ji...@apache.org>]

Sean Owen created SPARK-2903:
--------------------------------

             Summary: Spark SQL tests fail to compile due to dependency structure, misplaced test class
                 Key: SPARK-2903
                 URL: https://issues.apache.org/jira/browse/SPARK-2903
             Project: Spark
          Issue Type: Bug
          Components: Build, SQL
    Affects Versions: 1.0.1
            Reporter: Sean Owen
            Priority: Critical


(Pardon for marking Critical, but as far as I can tell master does not compile at all at the moment.)

Since recently, I find that the SQL modules' test code fails to compile with a simple "mvn clean compile test-compile". sql/core fails with a large number of errors, beginning like so:

{code}
[error] /Users/srowen/Documents/spark/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala:23: not found: type PlanTest
[error] class QueryTest extends PlanTest {
[error]                         ^
[error] /Users/srowen/Documents/spark/sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:28: package org.apache.spark.sql.test is not a value
[error]   test("SPARK-1669: cacheTable should be idempotent") {
...
{code}

I think a couple files and dependencies are in the wrong place, and it is resolved with the following:

- Move org.apache.spark.sql.test.TestSQLContext from under sql/core/src/*main*/scala, to sql/core/src/*test*/scala , which seems like where it belongs as test code
- Move org.apache.spark.sql.parquet.ParquetTestData likewise from main to test
- QueryTest in sql/core depends on PlanTest, which appears to be catalyst-specific, instead of FunSuite. It shouldn't, and isn't needed.
- Remove dependency from sql/core tests on sql/catalyst tests, which seems reversed
- Introduce dependency from sql/hive tests on sql/core tests to restore access to the files moved above

What I'm still not clear on is why it has only started failing to compile in the last week or so. But, these seem like the right changes to make. It compiles and tests pass.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org