[jira] [Commented] (FLINK-10174) getbytes with no charsets test error for hex and toBase64

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585534#comment-16585534 ] 

ASF GitHub Bot commented on FLINK-10174:
----------------------------------------

xueyumusic opened a new pull request #6579: [FLINK-10174][table] fix getbytes in hex and toBase64
URL: https://github.com/apache/flink/pull/6579
 
 
   ## What is the purpose of the change
   Hex and toBase64 builtin method use str.getBytes() with no Charset. It maybe depend on local execution environment for special Unicode and maybe result in errors when test Hex for special Unicode
   
   
   ## Brief change log
   
   using str.getBytes(Charsets.UTF_8) instead of str.getBytes()
   
   
   ## Verifying this change
   add tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> getbytes with no charsets test error for hex and toBase64
> ---------------------------------------------------------
>
>                 Key: FLINK-10174
>                 URL: https://issues.apache.org/jira/browse/FLINK-10174
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: xueyu
>            Assignee: xueyu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Hex and toBase64 builtin method use str.getBytes() with no Charset. It maybe depend on local execution environment for special Unicode and maybe result in errors when test Hex for special Unicode



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)