You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "ywcb00 (via GitHub)" <gi...@apache.org> on 2026/09/09 13:23:07 UTC

[PR] [SYSTEMDS-3963] Deactivate the Java Code Formatter in the GitHub Workflows [systemds]

ywcb00 opened a new pull request, #2608:
URL: https://github.com/apache/systemds/pull/2608

   Hi,
   this PR deactivates the java formatter in the GitHub workflows, since applying the code style formatting sometimes results in actual code changes. Deactivating the formatter is just a temporary answer to this problem. The code style demands an actual rework.
   @janniklinde do you agree to deactivating the formatting workflow temporarily?
   
   All the best,
   David


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3963] Deactivate the Java Code Formatter in the GitHub Workflows [systemds]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2608:
URL: https://github.com/apache/systemds/pull/2608#issuecomment-5602740256

   ## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2608?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 74.93%. Comparing base ([`d3670af`](https://app.codecov.io/gh/apache/systemds/commit/d3670afb60ecee9c7df0530d41f3b75d2cf73f3c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e37d508`](https://app.codecov.io/gh/apache/systemds/commit/e37d5082a8525a81453195b12510368314291034?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               main    #2608       +/-   ##
   =============================================
   + Coverage     71.74%   74.93%    +3.18%     
   =============================================
     Files          2074      436     -1638     
     Lines        222109    25237   -196872     
     Branches      38253        0    -38253     
   =============================================
   - Hits         159358    18911   -140447     
   + Misses        51672     6326    -45346     
   + Partials      11079        0    -11079     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/systemds/pull/2608/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [java](https://app.codecov.io/gh/apache/systemds/pull/2608/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [python](https://app.codecov.io/gh/apache/systemds/pull/2608/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.93% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/systemds/pull/2608?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3963] Deactivate the Java Code Formatter in the GitHub Workflows [systemds]

Posted by "ywcb00 (via GitHub)" <gi...@apache.org>.
ywcb00 closed pull request #2608: [SYSTEMDS-3963] Deactivate the Java Code Formatter in the GitHub Workflows
URL: https://github.com/apache/systemds/pull/2608


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3963] Deactivate the Java Code Formatter in the GitHub Workflows [systemds]

Posted by "janniklinde (via GitHub)" <gi...@apache.org>.
janniklinde commented on PR #2608:
URL: https://github.com/apache/systemds/pull/2608#issuecomment-5603159829

   > Hi, this PR deactivates the java formatter in the GitHub workflows, since applying the code style formatting sometimes results in actual code changes. Deactivating the formatter is just a temporary answer to this problem. The code style demands an actual rework. @janniklinde do you agree to deactivating the formatting workflow temporarily?
   > 
   > All the best, David
   
   LGTM @ywcb00. Until those formatter issues are addressed, we should deactivate this workflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3963] Deactivate the Java Code Formatter in the GitHub Workflows [systemds]

Posted by "ywcb00 (via GitHub)" <gi...@apache.org>.
ywcb00 commented on PR #2608:
URL: https://github.com/apache/systemds/pull/2608#issuecomment-5603132331

   I have also added the necessity to call the formatter shell script with the `--force` flag. Otherwise, a warning will be shown to inform the user that the formatter is currently not supported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org