You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/04/20 12:38:18 UTC

[GitHub] [kafka] dengziming commented on a diff in pull request #12071: KAFKA-13790; ReplicaManager should be robust to all partition updates from kraft metadata log (1)

dengziming commented on code in PR #12071:
URL: https://github.com/apache/kafka/pull/12071#discussion_r854082813


##########
clients/src/main/resources/common/message/LeaderAndIsrRequest.json:
##########
@@ -78,8 +78,8 @@
         "about": "The leader epoch." },
       { "name": "Isr", "type": "[]int32", "versions": "0+", "entityType": "brokerId",
         "about": "The in-sync replica IDs." },
-      { "name": "ZkVersion", "type": "int32", "versions": "0+",
-        "about": "The ZooKeeper version." },
+      { "name": "PartitionEpoch", "type": "int32", "versions": "0+",
+        "about": "The current epoch for the partition for KRaft controllers. The current ZK version for the legacy controllers." },

Review Comment:
   It seems LeaderAndIsrRequest is only used in ZkController and will be removed after KIP-500, will we use it in KRaft mode?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org