You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nicolás Lichtmaier <ni...@reloco.com.ar> on 2004/04/03 17:28:45 UTC
I18n patch
Adaptations for i18n.
* Marked up internationalizable strings with _()/N_().
* subversion/libsvn_subr/opt.c
(print_command_info,svn_opt_format_option): Pass help strings to
gettext before printing them.
Re: I18n patch
Posted by Nicolás Lichtmaier <ni...@reloco.com.ar>.
Beware, this shouldn't have been part of the patch file:
> svn_pool_destroy (pool);
>@@ -1246,10 +1248,8 @@ main (int argc, const char * const *argv
> #ifdef SIGTERM
> apr_signal (SIGTERM, signal_handler);
> #endif
>-
> #ifdef SIGPIPE
>- /* Disable SIGPIPE generation for the platforms that have it. */
>- apr_signal(SIGPIPE, SIG_IGN);
>+ apr_signal(SIGPIPE, signal_handler);
> #endif
>
> /* And now we finally run the subcommand. */
>
>
And I forgot a log entry:
* subversion/po/es.po
Updated.
=)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: I18n patch
Posted by Nicolás Lichtmaier <ni...@reloco.com.ar>.
>> Adaptations for i18n.
>> * Marked up internationalizable strings with _()/N_().
>> * subversion/libsvn_subr/opt.c
>> (print_command_info,svn_opt_format_option): Pass help strings to
>> gettext before printing them.
>
> Note that you are still modifying the apr_signal() call. Why?
>
> To help make the patch smaller, I'd suggest splitting it up into two:
> one which does the _()/N_() and gettext call, and another which
> updates the es.po file. They can be treated orthogonally and would
> shrink the size of the _() patch by a bit so it can be more easily
> reviewed. -- justin
Here it is again.
Re: I18n patch
Posted by Nicolás Lichtmaier <ni...@reloco.com.ar>.
>> Also, I'm not sure we can just unconditionally add calls to gettext,
>> if I'm
>> reading the headers right we also need to add a compat #define for the
>> non-nls case.
>
> Correct. It has to be protected with #ifdef ENABLE_NLS. -- justin
>
You just do
#ifndef ENABLE_NLS
#define gettext(x) (x)
#endif
...instead of cultering the code with ifdefs.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: I18n patch
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Saturday, April 3, 2004 12:58 PM -0500 Garrett Rooney
<ro...@electricjellyfish.net> wrote:
> Also, I'm not sure we can just unconditionally add calls to gettext, if I'm
> reading the headers right we also need to add a compat #define for the
> non-nls case.
Correct. It has to be protected with #ifdef ENABLE_NLS. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: I18n patch
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Apr 3, 2004, at 12:41 PM, Justin Erenkrantz wrote:
> --On Saturday, April 3, 2004 2:28 PM -0300 Nicolás Lichtmaier
> <ni...@reloco.com.ar> wrote:
>
>> Adaptations for i18n.
>> * Marked up internationalizable strings with _()/N_().
>> * subversion/libsvn_subr/opt.c
>> (print_command_info,svn_opt_format_option): Pass help strings to
>> gettext before printing them.
>
> Note that you are still modifying the apr_signal() call. Why?
>
> To help make the patch smaller, I'd suggest splitting it up into two:
> one which does the _()/N_() and gettext call, and another which
> updates the es.po file. They can be treated orthogonally and would
> shrink the size of the _() patch by a bit so it can be more easily
> reviewed. -- justin
Also, I'm not sure we can just unconditionally add calls to gettext, if
I'm reading the headers right we also need to add a compat #define for
the non-nls case.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: I18n patch
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Saturday, April 3, 2004 2:28 PM -0300 Nicolás Lichtmaier
<ni...@reloco.com.ar> wrote:
> Adaptations for i18n.
> * Marked up internationalizable strings with _()/N_().
> * subversion/libsvn_subr/opt.c
> (print_command_info,svn_opt_format_option): Pass help strings to
> gettext before printing them.
Note that you are still modifying the apr_signal() call. Why?
To help make the patch smaller, I'd suggest splitting it up into two: one
which does the _()/N_() and gettext call, and another which updates the es.po
file. They can be treated orthogonally and would shrink the size of the _()
patch by a bit so it can be more easily reviewed. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org