You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/06/23 09:42:59 UTC
[GitHub] flink issue #6203: [FLINK-9280][rest] Rework JobSubmitHandler to accept jar/...
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6203
There's a problem with how we designed the `FileUploads` cleanup. The `AbstractHandler` cleans it up when `AbstractHandler#respondToRequest` returns. There is however no guarantee that the request has been fully processed at this point, since `AbstractRestHandler` frequently processes requests asynchronously using `CompletableFutures`. In turn we may end up deleting files _before_ they have been processed or _while _ they are being processed.
It appears we can only handle the cleanup in `AbstractHandler` if we let `AbstractHandler#respondToRequest` return a `CompletableFuture` that marks the finished request processing.
---