You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/29 19:06:40 UTC
[GitHub] [incubator-kyuubi] zhaomin1423 opened a new pull request, #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
zhaomin1423 opened a new pull request, #2776:
URL: https://github.com/apache/incubator-kyuubi/pull/2776
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
close https://github.com/apache/incubator-kyuubi/issues/2745#issue-1248428722
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2776:
URL: https://github.com/apache/incubator-kyuubi/pull/2776#issuecomment-1146718400
please help me review it. @yaooqinn @pan3793 @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
URL: https://github.com/apache/incubator-kyuubi/pull/2776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2776:
URL: https://github.com/apache/incubator-kyuubi/pull/2776#discussion_r967757432
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/meta/ResultSetSchemaConstant.scala:
##########
@@ -37,6 +37,12 @@ object ResultSetSchemaConstant {
*/
final val TABLE_SCHEM = "TABLE_SCHEM"
Review Comment:
typo and duplicated with below TABLE_SCHEMA.
cc @lightning-L
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2776:
URL: https://github.com/apache/incubator-kyuubi/pull/2776#issuecomment-1157208368
The ci failed because of https://github.com/apache/incubator-kyuubi/pull/2816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2776:
URL: https://github.com/apache/incubator-kyuubi/pull/2776#issuecomment-1160044682
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2776:
URL: https://github.com/apache/incubator-kyuubi/pull/2776#issuecomment-1159909559
The doris container exception don't exist, there is a failure about LADP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2776: [KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2776:
URL: https://github.com/apache/incubator-kyuubi/pull/2776#issuecomment-1146579165
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2776](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac923a1) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/49352b5ac3376b82e91557ef40ad5ea6cb41ec76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49352b5) will **increase** coverage by `1.23%`.
> The diff coverage is `80.95%`.
```diff
@@ Coverage Diff @@
## master #2776 +/- ##
============================================
+ Coverage 61.79% 63.02% +1.23%
+ Complexity 385 219 -166
============================================
Files 433 481 +48
Lines 20345 21442 +1097
Branches 2760 2848 +88
============================================
+ Hits 12572 13514 +942
- Misses 6541 6648 +107
- Partials 1232 1280 +48
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/engine/jdbc/dialect/JdbcDialect.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1qZGJjLWVuZ2luZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvamRiYy9kaWFsZWN0L0pkYmNEaWFsZWN0LnNjYWxh) | `43.75% <ø> (ø)` | |
| [...yuubi/operation/meta/ResultSetSchemaConstant.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vbWV0YS9SZXN1bHRTZXRTY2hlbWFDb25zdGFudC5zY2FsYQ==) | `0.00% <ø> (ø)` | |
| [...yuubi/engine/jdbc/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1qZGJjLWVuZ2luZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvamRiYy9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `91.48% <50.00%> (+3.98%)` | :arrow_up: |
| [...ache/kyuubi/engine/jdbc/dialect/DorisDialect.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1qZGJjLWVuZ2luZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvamRiYy9kaWFsZWN0L0RvcmlzRGlhbGVjdC5zY2FsYQ==) | `58.82% <68.42%> (+15.07%)` | :arrow_up: |
| [...e/kyuubi/engine/jdbc/operation/JdbcOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1qZGJjLWVuZ2luZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvamRiYy9vcGVyYXRpb24vSmRiY09wZXJhdGlvbi5zY2FsYQ==) | `48.97% <90.90%> (+12.13%)` | :arrow_up: |
| [...i/engine/jdbc/operation/JdbcOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1qZGJjLWVuZ2luZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvamRiYy9vcGVyYXRpb24vSmRiY09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `37.83% <100.00%> (+18.60%)` | :arrow_up: |
| [...main/scala/org/apache/kyuubi/util/ClassUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS91dGlsL0NsYXNzVXRpbHMuc2NhbGE=) | `71.42% <0.00%> (-16.08%)` | :arrow_down: |
| [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.36% <0.00%> (-9.70%)` | :arrow_down: |
| [...thentication/KyuubiHttpAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvaHR0cC9hdXRoZW50aWNhdGlvbi9LeXV1YmlIdHRwQXV0aGVudGljYXRpb25GYWN0b3J5LnNjYWxh) | `80.00% <0.00%> (-8.00%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `76.92% <0.00%> (-7.70%)` | :arrow_down: |
| ... and [117 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [49352b5...ac923a1](https://codecov.io/gh/apache/incubator-kyuubi/pull/2776?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org