You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/25 02:53:44 UTC

[GitHub] [rocketmq-client-go] lampnick opened a new pull request, #908: fix:wrong stats log (#907)

lampnick opened a new pull request, #908:
URL: https://github.com/apache/rocketmq-client-go/pull/908

   ## What is the purpose of the change
   
   fix: wrong stats log(#907 )
   
   ## Brief changelog
   
   fix: wrong stats log(#907 )
   
   ## Verifying this change
   
   fix: wrong stats log(#907 )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] vongosling merged pull request #908: [ISSUE #907]remove useless stats log (#907)

Posted by GitBox <gi...@apache.org>.
vongosling merged PR #908:
URL: https://github.com/apache/rocketmq-client-go/pull/908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] lampnick commented on pull request #908: [ISSUE #907]remove useless stats log (#907)

Posted by GitBox <gi...@apache.org>.
lampnick commented on PR #908:
URL: https://github.com/apache/rocketmq-client-go/pull/908#issuecomment-1228188735

   > would you like to add a new logic in another pr, to show sum and qps?
   
   The sum and tps was in current code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] vongosling commented on pull request #908: [ISSUE #907]remove useless stats log (#907)

Posted by GitBox <gi...@apache.org>.
vongosling commented on PR #908:
URL: https://github.com/apache/rocketmq-client-go/pull/908#issuecomment-1228174961

   would you like to add a new logic in another pr, to show sum and qps?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #908: fix:wrong stats log (#907)

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #908:
URL: https://github.com/apache/rocketmq-client-go/pull/908#issuecomment-1226880965

   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#908](https://codecov.io/gh/apache/rocketmq-client-go/pull/908?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a0fc5b) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/26303836092a1fadbe4a1239c8abbcf504a36fce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2630383) will **not change** coverage.
   > The diff coverage is `33.33%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #908   +/-   ##
   =======================================
     Coverage   23.65%   23.65%           
   =======================================
     Files          52       52           
     Lines        7150     7150           
   =======================================
     Hits         1691     1691           
     Misses       5229     5229           
     Partials      230      230           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `72.85% <33.33%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org