You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/09/23 11:41:08 UTC

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #649: MINIFICPP-1024 - Fix third party dependencies

phrocker commented on issue #649: MINIFICPP-1024 - Fix third party dependencies
URL: https://github.com/apache/nifi-minifi-cpp/pull/649#issuecomment-534062835
 
 
   > > Looks good. I'll run some tests across platforms with various builds enabling and disabling features before merging. thanks!
   > 
   > Thanks, let me know if anything fails. This is a less complete fix than MINIFICPP-1022 will be, but it should make the builds running properly again.
   
   That's a good point. I had a failure on Windows but cleaned out my workspace and am working on another task. I'm good to merge this with a +1 since I haven't had time to re-validate the failure wasn't something in a polluted workspace. If you and @arpadboda already attempted to build and deploy flows w/ PublishKafka on Windows and other platforms I'm good to merge. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services