[jira] [Commented] (TRINIDAD-2298) Add skin features to be added via SkinAddition

["Jeremy C. Hull (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426850#comment-13426850 ] 

Jeremy C. Hull commented on TRINIDAD-2298:
------------------------------------------

SkinAddition.compareTo()  was assuming the stylesheet could not be null, which is not the case, according to the XSD. Added handling for a null stylesheet name as part of this patch. 
                
> Add skin features to be added via SkinAddition
> ----------------------------------------------
>
>                 Key: TRINIDAD-2298
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2298
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>    Affects Versions: 2.0.1-core
>            Reporter: Jeremy C. Hull
>            Priority: Minor
>         Attachments: skinAdditionFeatures.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Allow <features> element to be added as a child of <skin-addition> as a way of adding features without extending a skin. Have this working, just need to generate a patch. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira